Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-24] [TS migration] Migrate 'AnchorForAttachmentsOnly' component to TypeScript #25121

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Not a priority Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/AnchorForAttachmentsOnly/index.native.js 4
src/components/AnchorForAttachmentsOnly/index.js 5
src/components/AnchorForAttachmentsOnly/anchorForAttachmentsOnlyPropTypes.js 2
src/components/AnchorForAttachmentsOnly/BaseAnchorForAttachmentsOnly.js 13
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@ruben-rebelo
Copy link
Contributor

I am Ruben Rebelo from Callstack - expert contributor group. I’d like to work on this job.

Copy link
Author

melvin-bot bot commented Dec 21, 2023

📣 @ruben-rebelo! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Copy link
Author

melvin-bot bot commented Jan 4, 2024

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Jan 12, 2024
Copy link
Author

melvin-bot bot commented Jan 12, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 17, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'AnchorForAttachmentsOnly' component to TypeScript [HOLD for payment 2024-01-24] [TS migration] Migrate 'AnchorForAttachmentsOnly' component to TypeScript Jan 17, 2024
Copy link
Author

melvin-bot bot commented Jan 17, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 17, 2024
Copy link
Author

melvin-bot bot commented Jan 17, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-24. 🎊

Copy link
Author

melvin-bot bot commented Jan 17, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Gonals] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@Gonals
Copy link
Contributor

Gonals commented Jan 17, 2024

This is a migration, so we shouldn't need new tests

@slafortune
Copy link
Contributor

@ruben-rebelo is an expert contributor from CallStack
@Gonals interanal Expensify

No payment required.

@sobitneupane
Copy link
Contributor

@slafortune I reviewed the associated PR. Can you please assign me the issue. I will require payment summary to request payment.

@sobitneupane
Copy link
Contributor

Requested $250 (TS Migration) in newDot for reviewing associated PR

@JmillsExpensify
Copy link

Re-opening for the payment summary.

@slafortune
Copy link
Contributor

@ruben-rebelo is an expert contributor from CallStack - no payment required
@Gonals internal Expensify - no payment required
@sobitneupane PR review - due $250 to be paid via newdot.

@JmillsExpensify
Copy link

$250 approved for @sobitneupane based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Not a priority Task Typescript Migration Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

5 participants