[HOLD for payment 2023-08-21] [$1000] Web -Pointer cursor is displayed on send button even when compose box is empty

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report and hover on send button

Expected Result:

'not-allowed' cursor should be displayed on send button when there is no text in compose box

Actual Result:

Pointer cursor is displayed on send button even when there is no text in compose box

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.47-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

pointer.cursor.displayed.on.send.button.mp4

Recording.3987.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690618580440309

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fb9c3994ff691de4
• Upwork Job ID: 1685975218636345344
• Last Price Increase: 2023-07-31
• Automatic offers:
• dhanashree-sawant | Reporter | 25955399
• Nodebrute | Contributor | 25990051

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @PauloGasparSv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[c3024]

Edited as the earlier RCA was incorrect

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pointer is shown on Send button when the compose box is empty.

What is the root cause of that problem?

PR 22227 removed the disabled prop of Pressable and added it to the Tap. So there is default pointer for Pressable at all times

What changes do you think we should make in order to solve the problem?

We can use

pointerEvents = {this.state.isCommentEmpty || isBlockedFromConcierge || this.props.disabled || hasExceededMaxCommentLength ? 'none' : 'auto'}
                                    

on the Pressable.
or add to style,

{cursor: this.state.isCommentEmpty || isBlockedFromConcierge || this.props.disabled || hasExceededMaxCommentLength ? "not-allowed" : 'auto'}

and conditionally show the tooltip for the send button.

What alternative solutions did you explore? (Optional)

[Beamanator]

@c3024 that looks exactly why this is failing 👍

Do you have a chance to put up a PR quickly?

[c3024]

Yes, will make it right away.

[Beamanator]

Actually it looks like disabled was removed here: #22227

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Beamanator]

Thanks @c3024 ! assigned!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fb9c3994ff691de4

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[Pujan92]

Ok, somehow it gave me a little bad UX feeling so I thought to share it here.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• pointerFix #24223

If no regressions arise, payment will be issued on 2023-08-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rushatgabhane does not require payment (Eligable for Manual Requests)
• @Nodebrute requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[laurenreidexpensify]

Payment Summary:

• External issue reporter - @dhanashree-sawant - $250, job accepted in Upwork
• Contributor that fixed the issue - @Nodebrute - $1000 + $500 urgency bonus, job accepted in Upwork
• Contributor+ that helped on the issue and/or PR - @rushatgabhane $1000 + $500 urgency bonus, please request in newdot

[laurenreidexpensify]

Updated Payment Summary:

External issue reporter - @dhanashree-sawant - $250, paid in Upwork
Contributor that fixed the issue - @Nodebrute - $1000 + $500 urgency bonus, paid in Upwork
Contributor+ that helped on the issue and/or PR - @rushatgabhane $1000 + $500 urgency bonus, please request in newdot

@rushatgabhane please complete teh final steps above so we can close this out. Thanks

[rushatgabhane]

im waiting for existing manual requests to be approved.
i'll complete final steps once that's done

[laurenreidexpensify]

Not overdue - waiting on Rushat's payment to be approved.

[laurenreidexpensify]

Still waiting on Rushat's final payment cc @JmillsExpensify

[melvin-bot]

@PauloGasparSv, @rushatgabhane, @laurenreidexpensify, @Nodebrute Eep! 4 days overdue now. Issues have feelings too...

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: #10148 — The message got sent but it also stayed in the compose box #22227

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/22227/files#r1315354049

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A. part of checklist

4. Determine if we should create a regression test for this bug. No

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

[rushatgabhane]

Created a manual request here - https://staging.new.expensify.com/r/108474191068853

[laurenreidexpensify]

Closing - all steps complete

[JmillsExpensify]

$1,500 payment approved for @rushatgabhane based on BZ summary.