Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - No message for successful payment after adding bank account on requester end #23680

Closed
1 of 6 tasks
kbecciv opened this issue Jul 26, 2023 · 6 comments
Closed
1 of 6 tasks
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Jul 26, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #20821

Action Performed:

Precondition:
As User A,

  1. Create a workspace.
  2. Invite User B.
  3. Add Chase bank account to the workspace.

  1. Go to staging.new.expensify.com
  2. As User B, go to the workspace chat and request money.
  3. As User A, click Pay on IOU preview.
  4. As User A, click Pay with Expensify on IOU details page.
  5. As User B, go to IOU details page and click Add Bank Account.
  6. As User B, proceed with bank account page.

Expected Result:

After saving bank account information, the payment is successful and user should see the message 'paid using Expensify'.

Actual Result:

After saving bank account information, the message 'paid using Expensify' is not shown.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.46-0
Reproducible in staging?: y
Reproducible in production?: unable to verify the bank flow in production
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6142631_bandicam_2023-07-27_00-52-45-724.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jul 26, 2023
@kbecciv
Copy link
Author

kbecciv commented Jul 26, 2023

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@luacmartins
Copy link
Contributor

@kbecciv can you confirm if the personal bank account added is the same as the bank account added to the workspace? If so, the payment will fail and not seeing a message is expected.

@kbecciv
Copy link
Author

kbecciv commented Jul 26, 2023

@luacmartins When tester added a different bank as User B (checking 0000) while User A's workspace uses Saving 1111 account, PR is Pass.

20821_-_Android.mp4

@luacmartins
Copy link
Contributor

Thanks for confirming! This is not a blocker then. Closing.

@marcaaron marcaaron removed the DeployBlockerCash This issue or pull request should block deployment label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants