App displays error of 'Please select one member' on invite message page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings
3. Open workspaces
4. Open any workspace
5. Open members
6. Click on invite
7. Select any 1 member and click next
8. Reload on invite message page and click invite
9. Again click invite, select any one user and click next
10. Observe that app displays 'Please select one member' error even though user is selected and it allows to invite

Expected Result:

App should not display 'Please select one member' error if user is already selected on invite message page

Actual Result:

App displays 'Please select one member' error if we select user, reload on invite message page, click on invite, select new user and click next to again visit invite message page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Error.display.on.invite.message.page.mov

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689575732247029

View all open jobs on GitHub

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App displays error of 'Please select one member' on invite message page

What is the root cause of that problem?

When we reload the invite message page and invite the user, we navigate to WorkspaceMemberspage and WorkspaceInviteMessagePage is already in navigation stack with invitedEmailsToAccountIDsDraft prop is empty.

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Line 127 in 67bac9d

Navigation.navigate(ROUTES.getWorkspaceMembersRoute(this.props.route.params.policyID));

After we select any user and go to WorkspaceInviteMessagePage page again, the WorkspaceInviteMessagePage page that is already in navigation stack above has invitedEmailsToAccountIDsDraft prop is empty makes the error appear.

What changes do you think we should make in order to solve the problem?

We can navigate with type as UP to replace WorkspaceInviteMessagePage from navigation stack

Navigation.navigate(ROUTES.getWorkspaceMembersRoute(this.props.route.params.policyID), 'UP');

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Line 127 in 67bac9d

Navigation.navigate(ROUTES.getWorkspaceMembersRoute(this.props.route.params.policyID));

What alternative solutions did you explore? (Optional)

We also can add the check this.props.isFocused here to prevent the error appears

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Line 152 in 67bac9d

if (_.isEmpty(this.props.invitedEmailsToAccountIDsDraft)) {

Result

Screencast.from.17-07-2023.15.58.45.webm

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[makiour]

Dupe #23311

[dukenv0307]

It is reported first in Slack.

[dhanashree-sawant]

Yes in this case, both @dukenv0307 and @makiour are correct, I have commented on that issue and I think they will change the reporting name once they are available. We can close this issue.

[melvin-bot]

@michaelhaxhiu Whoops! This issue is 2 days overdue. Let's get this updated quick!

[michaelhaxhiu]

all set

[michaelhaxhiu]

thanks for the input yall