[HOLD for payment 2023-06-21] [$1000] Chat - Page loads infinitely instead of error page when accessing invalid link

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Scenario 1:

1. Copy IOU link which the logged-in user does not have access to.
2. Paste it on a new tab.

Scenario 2:

1. Go to https://staging.new.expensify.com/
2. Copy a chat link.
3. Paste it on the browser.

Scenario 3:

1. Go to invalid chat link. For example, https://staging.new.expensify.com/r/1234.

Expected Result:

Scenario 1: User lands on error page because they do not have access to the link.
Scenario 2: User is able to open the chat link.
Scenario 3: User lands on error page because they do not have access to the link.

Actual Result:

Scenario 1: User lands on the page which loads infinitely instead of error page.
Scenario 2: User is able to open the chat link.
Scenario 3: User lands on the page which loads infinitely instead of error page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.25.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6083700_bandicam_2023-06-07_23-54-48-588.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team / @adeel0202

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686035561587859

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0164184e82be52ad8b
• Upwork Job ID: 1666509686563983360
• Last Price Increase: 2023-06-07

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0164184e82be52ad8b

[melvin-bot]

Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Triggered auto assignment to @aldo-expensify (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[aldo-expensify]

In the scenario 3, I also see that the OpenReport request is sent a LOT of times:

[aldo-expensify]

@abekkala , this look like something Internal as the server is not sending any error data for onyx

Update: I'm wrong, it was a change in the front.

[melvin-bot]

Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @aldo-expensify is eligible for the External assigner, not assigning anyone new.

[aldo-expensify]

This seems to be a regression caused by: #20076

[fedirjh]

@aldo-expensify Can you please assign me this issue as it is a regression indeed . we should assign @dukenv0307 as well.

[dukenv0307]

@fedirjh I'm investigating the PR now

[dukenv0307]

@fedirjh @aldo-expensify The PR is ready to review

[aldo-expensify]

Merged the fix, thanks @dukenv0307 and @fedirjh !

[twisterdotcom]

Going to take this from April as it's a regression from my #19364

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix page loads infinitely #20407

If no regressions arise, payment will be issued on 2023-06-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[twisterdotcom]

Paid this out as a bonus to the linked #19364

[adeel0202]

Hi @twisterdotcom, I wasn't paid for reporting this bug (Scenario 1).

[adeel0202]

@twisterdotcom a friendly bump 😅

[aldo-expensify]

Reopening since there seem to be a pending payment

[twisterdotcom]

Sent the offer for this!

[twisterdotcom]

Paid.