[HOLD for payment 2023-06-21] [$1000] Update user tooltips to include avatar, display name, and handle

[puneetlath]

Today our user tooltips look like this:

We want to update them to look like this:

Things to note:

1. The three elements on the tooltip are avatar, display name, handle
2. Handle is a new field that is being added to the personalDetails object in this back-end PR (Note: That back-end PR got reverted 😅 )
3. Display name and handle are not always present, so we should gracefully handle showing whichever of the three pieces of information we have available.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01630563c7656399b7
• Upwork Job ID: 1664697769214058496
• Last Price Increase: 2023-06-02

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01630563c7656399b7

[melvin-bot]

Triggered auto assignment to @mallenexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

Triggered auto assignment to @aldo-expensify (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[puneetlath]

Sorry @trjExpensify @aldo-expensify @mallenexpensify. I'll manage this one.

[jayeshmangwani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We have to update user tooltips to include an avatar, display name, and handle address, right now it is only the email address

What is the root cause of that problem?

This is more like a feature request before we only show the email

What changes do you think we should make in order to solve the problem?

Here at ReportActionItemSingle Component, we are showing actorEmail on ToolTip

App/src/pages/home/report/ReportActionItemSingle.js

Lines 103 to 110 in fc30ddc

	<Tooltip text={actorEmail}>
	<View>
	<Avatar
	containerStyles={[styles.actionAvatar]}
	source={avatarSource}
	/>
	</View>
	</Tooltip>

here, We need to remove the text prop and need to use renderTooltipContent for rendering Avatar, name and address
like this

        renderTooltipContent={()=> (
            <View>
                <Avatar
                    containerStyles={[styles.actionAvatar]}
                    source={avatarSource}
                />
                <Text>{name}</Text>
                <Text>@{handle}</Text>
            </View>
        )}

We have to handle a similar case for the email address beside Avatar In the Message header, At ReportActionItemSingle Component we have ReportActionItemFragment for rendering the email text and here we are passing tooltipText={actorEmail} and here we have to create a new prop renderTooltipContent for handling renderTooltipContent instead of text in ReportActionItemFragment, here we will pass renderTooltipContent with same Component we have created for ReportActionItemSingle Avatar

App/src/pages/home/report/ReportActionItemSingle.js

Lines 123 to 130 in fc30ddc

	{_.map(personArray, (fragment, index) => (
	<ReportActionItemFragment
	key={`person-${props.action.reportActionID}-${index}`}
	fragment={fragment}
	tooltipText={actorEmail}
	isAttachment={props.action.isAttachment}
	isLoading={props.action.isLoading}
	isSingleLine

App/src/pages/home/report/ReportActionItemFragment.js

Lines 146 to 153 in fc30ddc

	<Tooltip text={props.tooltipText}>
	<Text
	numberOfLines={props.isSingleLine ? 1 : undefined}
	style={[styles.chatItemMessageHeaderSender, props.isSingleLine ? styles.pre : styles.preWrap]}
	>
	{props.fragment.text}
	</Text>
	</Tooltip>

Result

upadte-name.mov

What alternative solutions did you explore? (Optional)

none

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update user tooltips which shows more details of the user instead of just email/loginid

What is the root cause of that problem?

Currently, we are only passing a string of the actor emailid/loginid for the user tooltip.

What changes do you think we should make in order to solve the problem?

For this new feature, we need to create a new general component called UserDetailsTooltipContent and pass that component within the function for renderTooltipContent prop of Tooltip component wherever we need to update the user tooltip part. UserDetailsTooltipContent component will be responsible for showing the required 3 fields details of the user based on the availability.

Similar kind of behaviour we have for reaction tooltip content here.

App/src/components/Reactions/ReportActionItemReactions.js

Lines 74 to 76 in fc30ddc

	<Tooltip
	renderTooltipContent={() => (
	<ReactionTooltipContent

[puneetlath]

@Nikhil-Vats yes!

[Nikhil-Vats]

@puneetlath Thanks, I will work on one then!

[Christinadobrzyn]

Hi! - I think this other GH #20052 is the same issue as this one, could you please take a peek and let me know if you agree?

[fedirjh]

@Christinadobrzyn I think issues are different, this is a new feature where we will update existing tooltips , however the other issue #20052 , the tooltip itself is missing

[puneetlath]

Love the thorough review @fedirjh. @cloudpresser let's do it.

[melvin-bot]

📣 @cloudpresser You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[puneetlath]

@cloudpresser what's your ETA for when you could have a PR up?

[cloudpresser]

@puneetlath I will have a PR tomorrow before 12pm EST.

[puneetlath]

PR is close to merging.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Cloudpresser/user details tooltip #20276

If no regressions arise, payment will be issued on 2023-06-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter n/a
• Contributor that fixed the issue @cloudpresser
• Contributor+ that helped on the issue and/or PR @fedirjh

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[grgia]

Commented on the PR as well, but I think we need to handle workspace avatars case: https://expensify.slack.com/archives/C049HHMV9SM/p1686821040533159

[puneetlath]

@cloudpresser @fedirjh sorry for the delay. Sent you both hiring offers.

[fedirjh]

@puneetlath Thanks, accepted.

[puneetlath]

@cloudpresser friendly bump on accepting the Upwork offer. That way I can get you paid and we can close out this issue. Thanks!

[cloudpresser]

@puneetlath Accepted, thanks

[puneetlath]

All paid. Thanks for the effort everyone! Looking forward to your future contributions 💪🏾