Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentions styling doesn't render properly on native devices #19299

Open
puneetlath opened this issue May 19, 2023 · 34 comments
Open

Mentions styling doesn't render properly on native devices #19299

puneetlath opened this issue May 19, 2023 · 34 comments
Assignees
@puneetlath @parasharrajat @BartoszGrajdek
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2

Comments

@puneetlath
Copy link
Contributor

puneetlath commented May 19, 2023 •
edited
Loading

On native devices (iOS and Android) the padding and border-radius on the mentions background doesn't render. This is a react native issue with nested Text elements.

image

This is being addressed in: #4733

Once that is done, we should be able to make styling work on native devices.

Issue reporter: @parasharrajat

Issue OwnerCurrent Issue Owner: @BartoszGrajdek
@puneetlath puneetlath added Weekly KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 19, 2023
@puneetlath puneetlath self-assigned this May 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Current assignee @puneetlath is eligible for the Bug assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@puneetlath puneetlath added Weekly KSv2 and removed Daily KSv2 labels May 19, 2023
@melvin-bot melvin-bot bot added the Overdue label May 29, 2023
@puneetlath
Copy link
Contributor Author

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label May 29, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 6, 2023
@puneetlath
Copy link
Contributor Author

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Jun 7, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 15, 2023
@puneetlath
Copy link
Contributor Author

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Jun 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 30, 2023
@puneetlath
Copy link
Contributor Author

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Jul 2, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 10, 2023
@puneetlath
Copy link
Contributor Author

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Jul 11, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 19, 2023
@puneetlath
Copy link
Contributor Author

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Jul 24, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 1, 2023
@puneetlath
Copy link
Contributor Author

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Aug 2, 2023
@puneetlath
Copy link
Contributor Author

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Apr 23, 2024
@melvin-bot melvin-bot bot added the Overdue label May 24, 2024
@puneetlath
Copy link
Contributor Author

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label May 30, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 1, 2024
@puneetlath
Copy link
Contributor Author

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Jul 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 2, 2024
@puneetlath
Copy link
Contributor Author

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Aug 7, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 9, 2024
@puneetlath
Copy link
Contributor Author

Still on hold but getting close to un-hold.

@melvin-bot melvin-bot bot removed the Overdue label Oct 6, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
@puneetlath puneetlath changed the title [HOLD #27913] Mentions styling doesn't render properly on native devices Mentions styling doesn't render properly on native devices Dec 3, 2024
@puneetlath
Copy link
Contributor Author

@cdOut I'm curious what you think about this one. Is it similar to #27913?

@melvin-bot melvin-bot bot removed the Overdue label Dec 3, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 6, 2025
@puneetlath
Copy link
Contributor Author

Looking for assignee here: https://expensify.slack.com/archives/C04878MDF34/p1736352857632809?thread_ts=1734116044.243149&cid=C04878MDF34

@melvin-bot melvin-bot bot removed the Overdue label Jan 8, 2025
@BartoszGrajdek
Copy link
Contributor

Hi! @puneetlath I'm from the react-native-live-markdown team and I'll check what are the next steps here. I currently have some issues with higher priority I'm working on, but once I get these solved this is something I can look into 👀

You can go ahead and assign me to this issue 🙌🏻

@parasharrajat
Copy link
Member

Awesome, @BartoszGrajdek

@289Adam289 289Adam289 mentioned this issue Jan 29, 2025
Merged
50 tasks
@Kicu Kicu mentioned this issue Feb 24, 2025
Merged
@melvin-bot melvin-bot bot added the Overdue label Mar 3, 2025
@puneetlath
Copy link
Contributor Author

@BartoszGrajdek have you had a chance to look into this yet?

@melvin-bot melvin-bot bot removed the Overdue label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@puneetlath puneetlath

@parasharrajat parasharrajat

@BartoszGrajdek BartoszGrajdek

Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@puneetlath @parasharrajat @BartoszGrajdek