Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-05-29] [HOLD for payment 2023-05-25] Deleting thread replies results in "0 Replies" #19042

Closed
grgia opened this issue May 16, 2023 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@grgia
Copy link
Contributor

grgia commented May 16, 2023

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e6f62bce1dabf496
  • Upwork Job ID: 1658518218156986368
  • Last Price Increase: 2023-05-16

https://expensify.slack.com/archives/C049HHMV9SM/p1684252528337349

Create a thread
Post one message in the thread
Delete the message you created in 2
See an unexpected result (0 replies) on the original room

Image

@grgia grgia added the Internal Requires API changes or must be handled by Expensify staff label May 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 16, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01e6f62bce1dabf496

@melvin-bot
Copy link

melvin-bot bot commented May 16, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @abdulrahuman5196 (Internal)

@grgia grgia self-assigned this May 16, 2023
@grgia
Copy link
Contributor Author

grgia commented May 16, 2023

cc @chiragsalian childCommentorCount not updated when deleting

@abdulrahuman5196
Copy link
Contributor

Kindly let me know once the PR is ready. Would be happy to jump in on the review.

@grgia grgia mentioned this issue May 17, 2023
65 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels May 17, 2023
@melvin-bot melvin-bot bot changed the title Deleting thread replies results in "0 Replies" [HOLD for payment 2023-05-25] Deleting thread replies results in "0 Replies" May 18, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 18, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented May 18, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.15-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-05-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 22, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-05-25] Deleting thread replies results in "0 Replies" [HOLD for payment 2023-05-29] [HOLD for payment 2023-05-25] Deleting thread replies results in "0 Replies" May 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.16-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-05-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@abdulrahuman5196
Copy link
Contributor

@grgia I think this issue is updated wrongly. It was already deployment 5 days back and payment due on 25/5.
And could you kindly add label, so that a automatic BZ member is assigned to this issue?

@grgia grgia added the Bug Something is broken. Auto assigns a BugZero manager. label May 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 24, 2023
@grgia
Copy link
Contributor Author

grgia commented May 24, 2023

@isabelastisser could you help with C+ internal review payment?

@Expensify Expensify deleted a comment from melvin-bot bot May 24, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Daily KSv2 labels May 24, 2023
@abdulrahuman5196
Copy link
Contributor

@isabelastisser Just to note. The bug is wrongly marked as 29/5. It payment due is on 25/5(Today).

@abdulrahuman5196
Copy link
Contributor

@isabelastisser Gentle ping on the payment.

@isabelastisser
Copy link
Contributor

Reviewing this now.

@isabelastisser
Copy link
Contributor

Hi @abdulrahuman5196 , I sent you the invite in Upwork. Please accept it and I will hire and process the payment asap. Thanks!

@abdulrahuman5196
Copy link
Contributor

@isabelastisser I have accepted the invite.

@isabelastisser
Copy link
Contributor

The payment was made, and we are all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

4 participants