Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Text input label is moving while adding a bank account to a workspace #18714

Closed
1 of 6 tasks
kbecciv opened this issue May 10, 2023 · 22 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented May 10, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #18468

Action Performed:

  1. Open the App
  2. Login
  3. Open Settings > Workspaces
  4. Open any existing workspace or create a new one if you don't have one
  5. Open Connect Bank Account > Connect Bank Manually or with Plaid
  6. Complete the 1st and 2nd step
  7. From the 3rd step, go back
  8. Verify the text input birthdate label is not moving

Expected Result:

The text input label is not moving

Actual Result:

The text input label is a little moving compared to other environments.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native (example device: SG M52)
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.12.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6049019_18468_Android.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f18692795ade1d13
  • Upwork Job ID: 1658893459664945152
  • Last Price Increase: 2023-05-17
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 10, 2023

Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 10, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@alex-mechler
Copy link
Contributor

@kbecciv Can you list what devices this was reproducible on? It seems to only affect a few specific devices. Samsung Galaxy S10 seems to be a device that we can get reproductions on

@melvin-bot melvin-bot bot added the Overdue label May 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 15, 2023

@arielgreen Huh... This is 4 days overdue. Who can take care of this?

@kbecciv
Copy link
Author

kbecciv commented May 15, 2023

@alex-mechler Issue reproduced on SG M52

@arielgreen
Copy link
Contributor

Thanks @kbecciv !

@melvin-bot melvin-bot bot removed the Overdue label May 16, 2023
@arielgreen arielgreen added the External Added to denote the issue can be worked on by a contributor label May 17, 2023
@melvin-bot melvin-bot bot changed the title Android - Bank Account- The text input label is a little moving [$1000] Android - Bank Account- The text input label is a little moving May 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 17, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01f18692795ade1d13

@melvin-bot
Copy link

melvin-bot bot commented May 17, 2023

Current assignee @arielgreen is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented May 17, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 17, 2023

Triggered auto assignment to @deetergp (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@arielgreen arielgreen changed the title [$1000] Android - Bank Account- The text input label is a little moving [$1000] Text input label is moving while adding a bank account to a workspace May 17, 2023
@melvin-bot melvin-bot bot added the Overdue label May 18, 2023
@arielgreen
Copy link
Contributor

Not overdue, the job was just created yesterday.

@melvin-bot melvin-bot bot removed the Overdue label May 19, 2023
@fabioh8010
Copy link
Contributor

Hi I'm Fábio from Callstack - expert contributor group - I would like to take a look at this issue

@fedirjh
Copy link
Contributor

fedirjh commented May 19, 2023

@mountiny, could you please assign him?

@melvin-bot melvin-bot bot added the Overdue label May 22, 2023
@fedirjh
Copy link
Contributor

fedirjh commented May 22, 2023

Still awaiting proposals

@melvin-bot melvin-bot bot removed the Overdue label May 22, 2023
@fabioh8010
Copy link
Contributor

Update: I wasn't able to reproduce this issue on the emulator, as stated before it seems to be very device-specific. I asked a team member which has a Galaxy A32 (Android 11) to test and he wasn't able to reproduce it.

XRecorder_Edited_22052023_154317.mp4

Tomorrow I'll ask another team member that has a Galaxy S9 to try to test and reproduce the issue.


Note: It's not related to this issue and I'm not sure if it was already reported, but the checkbox text is "broken".

Screenshot_1684772823

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

📣 @fabioh8010 You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@arielgreen
Copy link
Contributor

@fedirjh @fabioh8010 please be sure to apply to the Upwork posting here.

@fabioh8010
Copy link
Contributor

Update: We tried another device, Samsung Galaxy S9 SM-G960F (Android 10), but again we weren't able to reproduce this issue.

Screen_Recording_20230523-154323_New.Expensify.1.mp4

I'm afraid that I won't be able to work on a fix for this issue, as I don't have the means to reproduce it. I also would like to reinforce that this kind of minor visual glitches that are very device-specific are usually not worth fixing it, as it can be a issue with a specific custom OS version or a range of devices of a specific brand. In most of these cases, the issue is with the custom OS / device itself and probably are not solvable.

@deetergp
Copy link
Contributor

@fabioh8010 @fedirjh @mountiny Should we just close this one then?

@fedirjh
Copy link
Contributor

fedirjh commented May 24, 2023

@deetergp As we are unable to reproduce the problem, it appears that there is no further action to be taken at this time. I propose to close this issue as it cannot be addressed without additional information or the ability to reproduce the bug.

@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

@deetergp @fabioh8010 @fedirjh @arielgreen this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@mountiny
Copy link
Contributor

Yes completely agree, thanks for digging into this Fabio.

I will close this out as there seems to be no payments due here, thanks!

@mountiny mountiny closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

7 participants