Request Money - Money request preview is displayed twice in chat if there are messages before payment

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to NewDot and login
2. Under accountA send money request to acountB
3. Send some more messages from A to B after that
4. Under accountB click Pay on preview and submit payment

Expected Result:

One IOU preview for one requested and paid amount should be in chat

Actual Result:

IOU preview for the same amount is displayed twice

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.12.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6048804_video_33.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

Putting Deploy Blocker label, issue is not reproductible in provided build https://18652.pr-testing.expensify.com/

Recording.2673.mp4

[marcaaron]

Asking for someone involved with Manual Requests project to take a look here. I'm not sure if this is the expected behavior or not, but seems likely related to changes we merged.

[marcaaron]

Maybe this PR? #18143

[JmillsExpensify]

Coming from Slack, just wanted to clarify that we decided to not block deploys on IOUs/manual requests issues. Stuff will break as we get this update out the door.

[marcaaron]

🖖

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Julesssss]

This is technically a bug with the isMostRecentIOU logic, but let's ignore it as the entire condition is about to be removed here (we'll always show the IOUPreview against an IOUAction).