[HOLD for payment 2023-05-23] [HOLD for payment 2023-05-16] [$1000] The invite members message page scrolls down and has a huge gap if copy pasted a long message multiple times in the message field #18566

kavimuru · 2023-05-07T20:07:29Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to web chrome
Create a new workspace
Go to invite members
Select any user and go to the message page
In the message , copy and paste a large sentence or to make work easier ,copy the existing message present and paste it multiple times until a vertical scrollbar is displayed on the right hand side of the screen
Now scroll the page down and notice that even though nothing is present, the page is scrollable down the invite button and has a huge gap

Expected Result:

The invite members message page should not be scrolled down if copy pasted a long message in the message field

Actual Result The invite members message page scrolls down and has a huge gap if copy pasted a long message in the message field

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.11.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

date-2023-05-07_09.40.15.mp4

Recording.523.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683432123152429

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01569b49604c9ee6e1
Upwork Job ID: 1655605551638052864
Last Price Increase: 2023-05-08

melvin-bot · 2023-05-07T20:07:33Z

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-05-07T20:07:35Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

hungvu193 · 2023-05-08T03:37:29Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The invite members message page scrolls down and has a huge gap if copy pasted a long message multiple times in the message field

What is the root cause of that problem?

We are using the autoGrowHeightprops for TextInput in here:

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Line 191 in d120f6a

autoGrowHeight

The autoGrowHeight props will add the hidden text input which doesn't have the limit height which caused the problem.

App/src/components/TextInput/BaseTextInput.js

Lines 376 to 384 in d120f6a

    
           {(this.props.autoGrow || this.props.autoGrowHeight) && ( 
        
               // Add +2 to width so that the first digit of amount do not cut off on mWeb - https://github.com/Expensify/App/issues/8158. 
        
               <Text 
        
                   style={[...this.props.inputStyle, this.props.autoGrowHeight ? {maxWidth: this.state.width} : {}, styles.hiddenElementOutsideOfWindow, styles.visibilityHidden]} 
        
                   onLayout={e => this.setState({textInputWidth: e.nativeEvent.layout.width + 2, textInputHeight: e.nativeEvent.layout.height})} 
        
               > 
        
                   {this.state.value || this.props.placeholder} 
        
               </Text>

What changes do you think we should make in order to solve the problem?

We can avoid using autoGrowHeight by using multiline TextInput. So our TextInput will look like:

   <TextInput
                                inputID="welcomeMessage"
                                label={this.props.translate('workspace.inviteMessage.personalMessagePrompt')}
                                autoCompleteType="off"
                                autoCorrect={false}
                                multiline
                                numberOfLines={numberOfLines}     
                                textAlignVertical="top"
                                containerStyles={[styles.workspaceInviteWelcome]}
                                defaultValue={this.state.welcomeNote}
                                value={this.state.welcomeNote}
                                onChangeText={text => this.setState({welcomeNote: text})}

What alternative solutions did you explore? (Optional)

melvin-bot · 2023-05-08T16:08:20Z

Job added to Upwork: https://www.upwork.com/jobs/~01569b49604c9ee6e1

melvin-bot · 2023-05-08T16:08:23Z

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-05-08T16:08:28Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

melvin-bot · 2023-05-08T16:08:33Z

Triggered auto assignment to @AndrewGable (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

bernhardoj · 2023-05-08T16:25:08Z

Looks like a regression from this #17202

parasharrajat · 2023-05-08T16:37:30Z

It seems so.

fedirjh · 2023-05-08T23:40:29Z

This should be fixed by ~~#18611~~ . It was a regression from #17202 and it will be fixed with another follow up PR.

melvin-bot · 2023-05-09T03:43:59Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Additional changes for #17202 #18611

If no regressions arise, payment will be issued on 2023-05-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-05-09T03:44:01Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@parasharrajat] Determine if we should create a regression test for this bug.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

parasharrajat · 2023-05-09T15:45:05Z

@AndrewGable It is a regression issue. Can you please assign @fedirjh to it as C+? Also, remove the Help Wanted labels

melvin-bot · 2023-05-09T16:36:39Z

📣 @fedirjh You have been assigned to this job by @lschurr!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

fedirjh · 2023-05-10T00:39:25Z

PR for fix : #18635

lschurr · 2023-05-16T16:08:42Z

@AndrewGable @fedirjh - just clarifying the payment date on this one. Should that have been reset since there was a regression?

fedirjh · 2023-05-16T16:13:06Z

cc @lschurr I think this will be automatically updated once the PR is deployed to production

parasharrajat · 2023-05-16T16:16:50Z

@lschurr This is itself a regression issue so there will not be payment except reporting for @priya-zha

lschurr · 2023-05-16T16:37:29Z

Thanks for clarifying @parasharrajat and @fedirjh!

lschurr · 2023-05-16T16:38:20Z

@priya-zha can you apply for the job so that we can pay the reporting bonus? https://www.upwork.com/jobs/~01569b49604c9ee6e1

priya-zha · 2023-05-16T16:46:03Z

Submitted the proposal. Thanks

lschurr · 2023-05-16T18:05:07Z

Payment issued for reporting. Do we need to keep this GH open @parasharrajat @fedirjh?

parasharrajat · 2023-05-16T18:06:51Z

No, All settled.

melvin-bot · 2023-05-16T22:56:42Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.14-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Further changes for #17202 #18635

If no regressions arise, payment will be issued on 2023-05-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-05-16T22:56:44Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 7, 2023

melvin-bot bot assigned lschurr May 7, 2023

lschurr added the External Added to denote the issue can be worked on by a contributor label May 8, 2023

melvin-bot bot assigned parasharrajat May 8, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 8, 2023

melvin-bot bot assigned AndrewGable May 8, 2023

Ollyws mentioned this issue May 8, 2023

Additional changes for #17202 #18611

Merged

56 tasks

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels May 9, 2023

Ollyws mentioned this issue May 9, 2023

Further changes for #17202 #18635

Merged

56 tasks

parasharrajat removed their assignment May 9, 2023

parasharrajat mentioned this issue May 9, 2023

[HOLD for payment 2023-05-23] [HOLD for payment 2023-05-16] [$1000] Editing workspace name to 1to3 characters adding extra line in the optional message when inviting users in Spanish #17202

Closed

6 tasks

lschurr assigned fedirjh May 9, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 9, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 15, 2023

lschurr removed the Awaiting Payment Auto-added when associated PR is deployed to production label May 16, 2023

lschurr closed this as completed May 16, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels May 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-05-23] [HOLD for payment 2023-05-16] [$1000] The invite members message page scrolls down and has a huge gap if copy pasted a long message multiple times in the message field #18566

[HOLD for payment 2023-05-23] [HOLD for payment 2023-05-16] [$1000] The invite members message page scrolls down and has a huge gap if copy pasted a long message multiple times in the message field #18566

kavimuru commented May 7, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented May 7, 2023

melvin-bot bot commented May 7, 2023 •

edited by lschurr

Loading

hungvu193 commented May 8, 2023

melvin-bot bot commented May 8, 2023

melvin-bot bot commented May 8, 2023

melvin-bot bot commented May 8, 2023

melvin-bot bot commented May 8, 2023

bernhardoj commented May 8, 2023

parasharrajat commented May 8, 2023

fedirjh commented May 8, 2023 •

edited

Loading

melvin-bot bot commented May 9, 2023

melvin-bot bot commented May 9, 2023

parasharrajat commented May 9, 2023 •

edited

Loading

melvin-bot bot commented May 9, 2023

fedirjh commented May 10, 2023

lschurr commented May 16, 2023

fedirjh commented May 16, 2023

parasharrajat commented May 16, 2023

lschurr commented May 16, 2023

lschurr commented May 16, 2023

priya-zha commented May 16, 2023

lschurr commented May 16, 2023

parasharrajat commented May 16, 2023

melvin-bot bot commented May 16, 2023

melvin-bot bot commented May 16, 2023

[HOLD for payment 2023-05-23] [HOLD for payment 2023-05-16] [$1000] The invite members message page scrolls down and has a huge gap if copy pasted a long message multiple times in the message field #18566

[HOLD for payment 2023-05-23] [HOLD for payment 2023-05-16] [$1000] The invite members message page scrolls down and has a huge gap if copy pasted a long message multiple times in the message field #18566

Comments

kavimuru commented May 7, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result The invite members message page scrolls down and has a huge gap if copy pasted a long message in the message field

Workaround:

Platforms:

melvin-bot bot commented May 7, 2023

melvin-bot bot commented May 7, 2023 • edited by lschurr Loading

Bug0 Triage Checklist (Main S/O)

hungvu193 commented May 8, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented May 8, 2023

melvin-bot bot commented May 8, 2023

melvin-bot bot commented May 8, 2023

melvin-bot bot commented May 8, 2023

bernhardoj commented May 8, 2023

parasharrajat commented May 8, 2023

fedirjh commented May 8, 2023 • edited Loading

melvin-bot bot commented May 9, 2023

melvin-bot bot commented May 9, 2023

parasharrajat commented May 9, 2023 • edited Loading

melvin-bot bot commented May 9, 2023

fedirjh commented May 10, 2023

lschurr commented May 16, 2023

fedirjh commented May 16, 2023

parasharrajat commented May 16, 2023

lschurr commented May 16, 2023

lschurr commented May 16, 2023

priya-zha commented May 16, 2023

lschurr commented May 16, 2023

parasharrajat commented May 16, 2023

melvin-bot bot commented May 16, 2023

melvin-bot bot commented May 16, 2023

kavimuru commented May 7, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented May 7, 2023 •

edited by lschurr

Loading

fedirjh commented May 8, 2023 •

edited

Loading

parasharrajat commented May 9, 2023 •

edited

Loading