Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] DEV: The characters like < in the description is displayed as &lt in the new money report but is displayed well on the chat report #18549

Closed
6 tasks
kavimuru opened this issue May 7, 2023 · 10 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed

Comments

@kavimuru
Copy link

kavimuru commented May 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to any single chat on web chrome
  2. Try to request money and make sure to add any text in description with <
  3. Notice that it displays '&lt' in the new money report down the cash text. But if you notice it is displayed well (<) in the chat report

Expected Result:

The characters like < in the description should be displayed as < in the new money report in a similar way how it is displayed on the chat report

Actual Result:

The characters like < in the description is displayed as &lt in the new money report but is displayed well on the chat report

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: Dev
Reproducible in staging?: N/a
Reproducible in production?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

date-2023-05-06_13.05.27.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683357783709189

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0127198fd6d1af3e0d
  • Upwork Job ID: 1656031768026296320
  • Last Price Increase: 2023-05-09
@kavimuru kavimuru added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels May 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 7, 2023

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 7, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Prince-Mendiratta
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

In this issue, we can notice that the description in IOU preview does not decode HTML characters and render it properly.

What is the root cause of that problem?

The comment in the originalMessage on any IOU action is HTML encoded. When rendering the description inside the IOU Preview, we do not decode the HTML for displaying it.

What changes do you think we should make in order to solve the problem?

We need to use Str.htmlDecode when displaying the description here:

<Text>{lodashGet(props.action, 'originalMessage.comment', '')}</Text>

What alternative solutions did you explore? (Optional)

None

@melvin-bot melvin-bot bot added the Overdue label May 9, 2023
@isabelastisser
Copy link
Contributor

Reviewing this now!

@melvin-bot melvin-bot bot removed the Overdue label May 9, 2023
@isabelastisser isabelastisser added the External Added to denote the issue can be worked on by a contributor label May 9, 2023
@melvin-bot melvin-bot bot changed the title DEV: The characters like < in the description is displayed as &lt in the new money report but is displayed well on the chat report [$1000] DEV: The characters like < in the description is displayed as &lt in the new money report but is displayed well on the chat report May 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0127198fd6d1af3e0d

@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

@isabelastisser isabelastisser removed the Needs Reproduction Reproducible steps needed label May 9, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 9, 2023

Triggered auto assignment to @danieldoglas (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@aimane-chnaif
Copy link
Contributor

@isabelastisser are you able to reproduce this on latest staging/production?

I fixed this myself in #18568

@isabelastisser isabelastisser added the Needs Reproduction Reproducible steps needed label May 10, 2023
@isabelastisser
Copy link
Contributor

Hey @aimane-chnaif, I can no longer reproduce this after I updated my chat. Thanks for the heads up, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

5 participants