Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-01] [HOLD for payment 2023-05-30][$1000] [Group 2][Accessible Pressable] Migrate RadioButtonWithLabel #17017

Closed
roryabraham opened this issue Apr 6, 2023 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Apr 6, 2023

HOLD on #16988

Description

Migrate RadioButtonWithLabel to use PressableWithFeedback

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013017b2499f5843db
  • Upwork Job ID: 1660715594165760000
  • Last Price Increase: 2023-05-22
@roryabraham roryabraham added the NewFeature Something to build that is a new item. label Apr 6, 2023
@roryabraham roryabraham self-assigned this Apr 6, 2023
@MelvinBot

This comment was marked as resolved.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 6, 2023
@roryabraham roryabraham added Monthly KSv2 and removed Weekly KSv2 labels Apr 6, 2023
@roryabraham roryabraham removed their assignment Apr 6, 2023
@roryabraham roryabraham moved this from HOLD to Todo in Accessible Pressables May 11, 2023
@roryabraham roryabraham changed the title [HOLD][Group 2][Accessible Pressable] Migrate RadioButtonWithLabel [Group 2][Accessible Pressable] Migrate RadioButtonWithLabel May 11, 2023
@melvin-bot melvin-bot bot added the Overdue label May 11, 2023
@robertKozik
Copy link
Contributor

Hi, if you could assign me to this issue. Here is draft PR: #18847

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue labels May 16, 2023
@roryabraham roryabraham moved this from Todo to In Progress in Accessible Pressables May 16, 2023
@abdulrahuman5196
Copy link
Contributor

@roryabraham
This PR was merged last week. Could you assign me for the PR review payment, so that when the week time is passed it would be processed by BZ

@roryabraham roryabraham added the External Added to denote the issue can be worked on by a contributor label May 22, 2023
@melvin-bot melvin-bot bot changed the title [Group 2][Accessible Pressable] Migrate RadioButtonWithLabel [$1000] [Group 2][Accessible Pressable] Migrate RadioButtonWithLabel May 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

Job added to Upwork: https://www.upwork.com/jobs/~013017b2499f5843db

@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

Triggered auto assignment to @isabelastisser (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels May 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

Current assignee @abdulrahuman5196 is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

Triggered auto assignment to @deetergp (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@roryabraham roryabraham removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 22, 2023
@roryabraham
Copy link
Contributor Author

@isabelastisser the PR for this has already been merged. All that's needed is to pay out the C+ reviewing bounty to @abdulrahuman5196 one week from our next production deploy. Assuming daily deploys, that means a week from tomorrow or 2023-05-30. Thanks!

@roryabraham roryabraham changed the title [$1000] [Group 2][Accessible Pressable] Migrate RadioButtonWithLabel [HOLD for payment 2023-05-30][$1000] [Group 2][Accessible Pressable] Migrate RadioButtonWithLabel May 22, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels May 25, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-05-30][$1000] [Group 2][Accessible Pressable] Migrate RadioButtonWithLabel [HOLD for payment 2023-06-01] [HOLD for payment 2023-05-30][$1000] [Group 2][Accessible Pressable] Migrate RadioButtonWithLabel May 25, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.17-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 31, 2023
@isabelastisser
Copy link
Contributor

@abdulrahuman5196 I hired you in Upwork, please accept the offer and I will process the payment asap. Thanks!

@github-project-automation github-project-automation bot moved this from In Progress to Done in Accessible Pressables Jun 1, 2023
@abdulrahuman5196
Copy link
Contributor

@isabelastisser Accepted the invite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Status: Done
Development

No branches or pull requests

7 participants