[HOLD for payment 2023-05-16] [$1000] Connect Bank Account - Beneficial owners Info isn't saved after going offline and return to connect new BA

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to the add bank account modal in Workspace settings
2. Start and follow the flow for adding a fully verified bank account using Wells Fargo bank(with the credentials found below) until the "Beneficial owners step"
3. Disable the internet connection
4. Toggle the last 2 checkboxes (terms and conditions and true information)
5. Fill out the form for an additional beneficial owner
6. Close the bank account setup modal but don't refresh the page
7. Navigate back to the bank account setup via Settings > Workspace > Connect Bank Account
8. Verify you see a full page blocking view saying You appear to be offline
9. Enable the internet connection in the device
10. Open Beneficial owners fields

Expected Result:

User lands on the Additional Information step and the Info for beneficial owner saved

Actual Result:

ser lands on the Additional Information step and the Info for beneficial owner is NOT saved

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.94.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6006115_Beneficial-Info.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d6555049f6d6ecae
• Upwork Job ID: 1648352908657057792
• Last Price Increase: 2023-04-25

[MelvinBot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[alexpensify]

I'll review this one on Friday.

[alexpensify]

We have a limited team online due to the Holiday weekend, so Concierge Ops assignments have taken a higher priority since there is a bigger pool to get through. I'll review this GH soon.

[alexpensify]

Early this week, I'll review this GH.

[MelvinBot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[alexpensify]

@AndrewGable - I've assigned the Engineering label to get feedback how we want this to function before assigning as External

[alexpensify]

@AndrewGable bumping this one

[AndrewGable]

Hey @alexpensify - This is a great question that I think we should take to Slack! It's my understanding that the Bug Zero team will be leading these type of decisions via Slack discussions.

[alexpensify]

I started a discussion here - https://expensify.slack.com/archives/C01GTK53T8Q/p1681417377815829

[alexpensify]

I bumped the thread to get more feedback and try to get this one assigned out early next week.

[alexpensify]

Not overdue

[alexpensify]

Ok, this is a great summary of how the experience should function:

The application should save the details of the beneficial owner (but we will block the user from submitting). Once the user is back online, those fields should be pre-populated for the person.

[alexpensify]

@AndrewGable - anything else to add here or am I good to add the External label?

[MelvinBot]

@AndrewGable @alexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01d6555049f6d6ecae

[MelvinBot]

Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[MelvinBot]

Current assignee @AndrewGable is eligible for the External assigner, not assigning anyone new.

[bernhardoj]

Will open the PR in a few hours

[bernhardoj]

PR is up.

[alexpensify]

Thank you! @Santhosh-Sellavel and @AndrewGable - we are ready for a PR review. 👏🏼

[alexpensify]

@Santhosh-Sellavel can we prioritize this PR review? Thank you!

[alexpensify]

@Santhosh-Sellavel - any update here? Thank you!

[Santhosh-Sellavel]

@alexpensify PR got merged on Staging now!

[alexpensify]

Thank you for the update! We will continue for the next automation step.

[alexpensify]

Still waiting for the automation here

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Change beneficial owners source of data from draft #18191

If no regressions arise, payment will be issued on 2023-05-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alexpensify]

@Santhosh-Sellavel - when you get a chance, can you fill out the checklist part above? Thank you!

[Santhosh-Sellavel]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: Fix/15544: Bank account pages disable text input within wrong data on main device #15772
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Fix/15544: Bank account pages disable text input within wrong data on main device #15772 (comment)
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A I believe this could have been caught during testing/review. No need to update anything on the checklist
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug. N/A applause has caught they should already have the test case for this one.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@AndrewGable Let me know if differ on any of the above.
@alexpensify Can you just confirm with applause that got a test case for this?

Thanks!

[alexpensify]

@AndrewGable - do you think we need to load this test in Test Rails? I don't think so, but let me know if you disagree.

[alexpensify]

To prepare for tomorrow, we have the following payouts. I see there is a 50% bonus because it was assigned on April 28 and was merged into production on May 3 (that's at the 3 business day mark):

Issue reporter: $250 - N/A (Internal)
Contributor: $1,500 - @bernhardoj
Contributor+: $1,500- @Santhosh-Sellavel

@AndrewGable and @Santhosh-Sellavel - Can you please 👍🏼 if you agree. Tomorrow, I'll complete the next steps in Upwork. Thank you!

[AndrewGable]

I don't think we need a TestRail

[alexpensify]

@bernhardoj and @Santhosh-Sellavel - I've prepared the payments in Upwork. Please accept and I can complete the process. Thank you!

[alexpensify]

I've been able to pay @bernhardoj via Upwork.

@Santhosh-Sellavel - please accept today because I'm going offline until next Wednesday. I don't want to delay the payment. Thank you.

[alexpensify]

@Santhosh-Sellavel has been paid via Upwork. I've closed the job too and am going to close this GitHub.