Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-04-03 #16880

Closed
21 tasks done
OSBotify opened this issue Apr 3, 2023 · 11 comments
Closed
21 tasks done

Deploy Checklist: New Expensify 2023-04-03 #16880

OSBotify opened this issue Apr 3, 2023 · 11 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Apr 3, 2023

Release Version: 1.2.94-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Apr 3, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Apr 3, 2023

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.94-0 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Apr 4, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.94-2 🚀

@mvtglobally
Copy link

mvtglobally commented Apr 4, 2023

Regression is completed

Blockers
Web - Chat - User can't type second ":" to finish emoji input in edit mode #16896
Chat - Infinity loading displayed for link Valid ID https://staging.new.expensify.com/r/1234 instead "You don't have access to this chat message" in the conversation history. #16897
Composer hidden while showing skeleton after login #16908
Workspace - Infinite loading displayed for second device after delete the Workspace as admin. #16915

PRs
PR #15880 is failing #16927. Repro in prod checking off
PR #16604 is failing #16892
PR #16705 is failing #16913
PR #16777 is failing #16893
We are also checking 2 new CPs

@OSBotify
Copy link
Contributor Author

OSBotify commented Apr 4, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.94-2 has been deployed to staging 🎉

@PauloGasparSv
Copy link
Contributor

Checking #16915 off as #16918 fixed this and was CP'd to staging. Could not replicate the issue on staging after that.

@thienlnam
Copy link
Contributor

thienlnam commented Apr 4, 2023

Checking off #16604 because it was fixed by this CP #16902

@thienlnam
Copy link
Contributor

Checking off 16896 #16902 (comment)

@OSBotify
Copy link
Contributor Author

OSBotify commented Apr 5, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.94-3 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Apr 5, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.94-3 has been deployed to staging 🎉

@mvtglobally
Copy link

#16922 checking off

@thienlnam
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants