[HOLD] [$1000] Fetch more attachments

[luacmartins]

Problem

Coming from #9279 (comment), we implemented an image carousel component but we do not fetch more attachments when we reach the end of client loaded reportActions, even if the chat report has more attachments.

Why is this important?

Users might reach the end of loaded reportActions and think they don't have any more attachments in the report, which causes confusion.

Solution

Create a new API command to return more attachments for the chat and call it within the attachment carousel component so that we load more attachments when we reach the end, similar to what we do for reportActions.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01edaff85b84a90ff7
• Upwork Job ID: 1637860885039116288
• Last Price Increase: 2023-03-23

Issue Owner

Current Issue Owner: @marcaaron

Issue Owner

Current Issue Owner: @marcaaron

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01edaff85b84a90ff7

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

[MelvinBot]

@aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[aimane-chnaif]

@luacmartins can you please assign engineer here? I am only the assignee.

[luacmartins]

Done!

[MelvinBot]

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MelvinBot]

Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Current assignee @luacmartins is eligible for the External assigner, not assigning anyone new.

[luacmartins]

This needs to be internal since we need to create a new API command for it.

[luacmartins]

No updates yet

[luacmartins]

I'm ooo this week, so no updates

[luacmartins]

I'm still working on other roadmap issues and won't be able to tackle this any time soon. I asked if anyone else is interested in working on this here

[luacmartins]

I'm focused on wave4 issues. I'll bump the slack thread again to look for volunteers to take this on.

[marcaaron]

Gonna pick this up from @luacmartins for now. If anyone wants to work on this with more urgency feel free to take the HOLD off and assign yourself.

[mallenexpensify]

@marcaaron 'll get to before long

[marcaaron]

One thing I've also noticed about the current feature is that it is also very slow when fetching the full size attachments in the carousel for a chat with a large history. Experienced this during Offshore when checking posts in #social.

So, I would maybe propose something like this:

• Only load a max of 3-5 attachments into the carousel at once (or figure out whatever makes it slow - I'd guess it's loading too many full size attachments)
• Load the "next" full size attachment when we move in either direction (left or right)
• Until we have comment linking we'll need an API that does something like:
  • When going "left"...
  • Check if there is an attachment in the report history
  • If so, return all reportActions between the oldest one we have and the attachment comment

I have some other thoughts - but I think it's still not quite a near-term priority so leaving the HOLD.

[marcaaron]

No updates.

[marcaaron]

Still not a priority. But feels like maybe it could move into a wave as a general chat improvement. The vsb room seems to be the most active channel for that type of stuff so I'll try to raise this there.

[mallenexpensify]

Posted
https://expensify.slack.com/archives/C066HJM2CAZ/p1702928367758539

[mallenexpensify]

Per discussion here we're going to close this to focus on near-term roadmap issues. We can reopen this when the time is right

[aimane-chnaif]

@mallenexpensify does team track all closed issues which will be reopened after wave?

[mallenexpensify]

@aimane-chnaif , currently, no. We'll be able to find any issues and would either reopen or link to/from them in the future. We discussed a few options for how to potentially track but none of them gained traction.