Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-02-15 #15175

Closed
22 tasks done
OSBotify opened this issue Feb 15, 2023 · 10 comments
Closed
22 tasks done

Deploy Checklist: New Expensify 2023-02-15 #15175

OSBotify opened this issue Feb 15, 2023 · 10 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Feb 15, 2023

Release Version: 1.2.72-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Feb 15, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Feb 15, 2023
@francoisl francoisl self-assigned this Feb 15, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.72-0 🚀

@mvtglobally
Copy link

@francoisl We are still working through regression. Below is the interim summary
Blocker
#15186

PR #14443 is failing #15188. It is not repro in PROD, but seems a new feature, so not sure if this would be a blocker.
PR #14873 is failing #15187. repro in PROD, checking off
#15037 is failing #15189. repro in PROD
#15104 is failing #15190. repro in PROD
#15117 we are blocked with this PR. we have no way to get debit card in non-passwordless account as debit is under beta too. and in Expensifail account DC is blocked with the error as well (old KI)

@mvtglobally
Copy link

Regression is completed

@francoisl
Copy link
Contributor

Thanks @mvtglobally! We're looking into these. I'll look into 14953 and 14769 as well, looks like they might need to be productionQA.

The last one I'm unsure though is #15049, did you have a chance to QA it?

@mvtglobally
Copy link

@francoisl forgot to update. We are facing the following on Desktop when testing #15049 #14876 (comment)

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.72-1 🚀

@francoisl
Copy link
Contributor

francoisl commented Feb 16, 2023

@francoisl
Copy link
Contributor

Checklist is cleared, waiting on iOS build to finish in https://github.com/Expensify/App/actions/runs/4197619678 and will close this

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.72-1 has been deployed to staging 🎉

@francoisl
Copy link
Contributor

:shipit:

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants