-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-01-25] IOU - White spaces appears in preview if spaces added in what's it for
as optional message
#14287
Comments
Triggered auto assignment to @sonialiap ( |
Job added to Upwork: https://www.upwork.com/jobs/~01e3c4da93ade354fc |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr ( |
what's it for
as optional messagewhat's it for
as optional message
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.55-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-01-25. 🎊 After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Done with the first 3 items in the checklist. @sonialiap all yours for the last item! |
Still waiting on the regression period for payment! |
Unassigning myself and @thesahindia should be assigned for the PR review, thanks! |
@sonialiap, it's ready for payment. |
@sonialiap have we handled all payments for this issue? Can we close this? |
To confirm payments to: Is this correct? |
It should be: @mollfpr got assigned because I added the internal label too late and @thesahindia had already reviewed the PR. |
Bump @sonialiap ^ |
Still waiting on payments |
Looks like @sonialiap is OOO @luacmartins |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
@mateocole Sonia is ooo, could you help with payment? |
looks like the old upwork job closed, can contributors apply here: https://www.upwork.com/jobs/~012706b583522bdff4 |
@mateocole applied |
Applied, thanks! |
Okay, contract sent! |
Okay all paid! |
@mateocole please close the upwork contract |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
should not show whitespaces
Actual Result:
for sent money shows whitespaces and for request money whitespace appears for a seconds
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.53-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Screen.Recording.2023-01-13.at.12.30.11.PM.mov
Recording.1281.mp4
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1673593293672519
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: