[HOLD for payment 2022-12-07] [Dark mode] Workspace icon inconsistent color

[aldo-expensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Have a workspace
2. Go to Settings > Workspaces
3. Notice that the workspace icon is green with a black building
   
4. Click the workspace
5. Notice that the big workspace icon is green with a white building
   

Expected Result:

I would expect these icons to be the same

Actual Result:

They have different color

Workaround:

N/A, just costmetic

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[aldo-expensify]

cc @grgia in case you are interested

[aldo-expensify]

@shawnborton is my expectation for the color of the building to be the same correct?

Bonus: Is this icon expected to have a black border?

[shawnborton]

Good catch - I think the outline currently behaves like that (even not in dark mode) but I think it's worth fixing everywhere.

[grgia]

Yep, I can take this one too

[melvin-bot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[grgia]

oops didnt mean to add design label, sorry shawn!

[melvin-bot]

@grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[grgia]

This should be fixed with the dark mode merge. (currently in DEV)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.33-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make the Switch to Dark Mode  #12944

If no regressions arise, payment will be issued on 2022-12-07. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@grgia] The PR that introduced the bug has been identified. Link to the PR:
• [@grgia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@grgia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: