Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Android - Blank space displayed under compose box on new conversations #10539

Closed
isagoico opened this issue Aug 24, 2022 · 26 comments
Closed
Assignees
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@isagoico
Copy link

isagoico commented Aug 24, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in the Android app
  2. Navigate to a new conversation
  3. Tap on the compose box to start writing

Expected Result:

Compose box is displayed on top of the keyboard without any blank spaces.

Actual Result:

There's a blank space under the compose box that is pushing the compose box to the top.

Note: this is not happening with conversations that have existing messages.

Workaround:

User can still type on the compose box but it unable to view the conversation area.

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.1.1-89

Reproducible in staging?: Yes
Reproducible in production?: No

Email or phone of affected tester (no customers): isagoicotest@gmail.com / 123456Isa

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

WhatsApp.Video.2022-08-24.at.1.16.27.PM.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause
Slack conversation: N/A

View all open jobs on GitHub

@isagoico isagoico added DeployBlockerCash This issue or pull request should block deployment Engineering Daily KSv2 labels Aug 24, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2022

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Aug 24, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@isagoico
Copy link
Author

As mentioned above, unable to reproduce the issue in production. Below is the behavior in prod app:

@sketchydroide
Copy link
Contributor

@isagoico do you have a video you can add? thanks it's easier to replicate/understand when there is a video

@isagoico
Copy link
Author

Yep! Adding it now - Looks like the "beginning of your chat" is not being rendered in the conversation 🤔 maybe this is happening because of that.

Attaching the video here and to the OC.

WhatsApp.Video.2022-08-24.at.1.16.27.PM.1.mp4

@roryabraham
Copy link
Contributor

Looking into this

@roryabraham roryabraham self-assigned this Aug 24, 2022
@roryabraham
Copy link
Contributor

The problem appears to be that the ReportActionsList isn't rendering at all:

image

And I saw this error which might be a hint:

image

@roryabraham
Copy link
Contributor

Diagnosed the problem, but don't have a fix ready

@dhairyasenjaliya
Copy link
Contributor

looks like this issue is the similar issue or might be the same which is logged here #10441

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Julesssss

This comment was marked as outdated.

@melvin-bot

This comment was marked as off-topic.

@melvin-bot

This comment was marked as off-topic.

@melvin-bot

This comment was marked as off-topic.

@melvin-bot
Copy link

melvin-bot bot commented Sep 30, 2022

Triggered auto assignment to @michaelhaxhiu for Upwork job creation (chore: ContributorPlusReview), see https://stackoverflow.com/c/expensify/questions/13732 for more details.

@tgolen
Copy link
Contributor

tgolen commented Sep 30, 2022

Trying to get a C+ review of #10648 not sure if I did it right 😓

@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2022

Current assignee @michaelhaxhiu is eligible for the ContributorPlusReview assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 3, 2022
@Julesssss
Copy link
Contributor

Hmm, I'm trying to get a C+ team member to review this improved fix PR. Does anyone know why this assigned a Contributor manager instead?

@Julesssss
Copy link
Contributor

posted in the C+ channel asking for help

@puneetlath puneetlath added the External Added to denote the issue can be worked on by a contributor label Oct 3, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2022

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 3, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2022

Current assignees @pecanoro, @Julesssss, and @roryabraham are eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot changed the title Android - Blank space displayed under compose box on new conversations [$250] Android - Blank space displayed under compose box on new conversations Oct 3, 2022
@Julesssss
Copy link
Contributor

Julesssss commented Oct 3, 2022

Hey @thesahindia 👋

Please review my PR here, which reverts a RN bugfix and replaces it with a native fix. Ideally, you would test on a physical Android device. But please let me know if you're not able to do this!

@thesahindia
Copy link
Member

Hey @Julesssss, it will take me a few hours. I had to reset my mac, it was acting funny😓

@michaelhaxhiu
Copy link
Contributor

Should this be open till #10648 is merged to prod?

@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2022

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests