[HOLD for payment 2022-09-26] [$250] Loading indicator isn't in center - Reported by @thesahindia

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings > Payments > Add payment method
2. Click on bank account

Expected Result:

The loading indicator should be in the center

Actual Result:

The loading indicator isn't in center

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.88-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screenrecording_20220726_175922.mp4

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1658840250275259

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @flaviadefaria (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[varshamb]

Hi, this is my first proposal, please let me know if any further changes are required.

Proposal

Add styles.flex1 to this View

App/src/pages/AddPersonalBankAccountPage.js

Line 167 in dbd87e0

<View style={[styles.mh5, styles.mb5]}>

[melvin-bot]

@flaviadefaria 10 days overdue. I'm getting more depressed than Marvin.

[flaviadefaria]

Doesn't seem like a priority but adding the engineering label.

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

@jliexpensify Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@jliexpensify Still overdue 6 days?! Let's take care of this!

[flaviadefaria]

@jliexpensify is on leave so will reapply the label.

[melvin-bot]

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[kadiealexander]

https://www.upwork.com/ab/applicants/1565628956228489216/job-details
https://www.upwork.com/jobs/~01141ec09bdbf1fab9

[melvin-bot]

📣 @varshamb You have been assigned to this job by @kadiealexander!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[kadiealexander]

Just adding a note that I'll be OOO for the next 9 days, until September 21st. If you need a CM in that time, please re-add the external label.

[jasperhuangg]

@kadiealexander Thanks for the update, the PR was just merged so I think I'll reassign the label since payout will need to be handled 👍

[melvin-bot]

Triggered auto assignment to @arielgreen (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[jasperhuangg]

@kadiealexander Thanks for the update, the PR was just merged so I think I'll reassign the label since payout will need to be handled 👍

@arielgreen Just so you're aware!

[Santhosh-Sellavel]

PR is merged and on staging now

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.1-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Center loading indicator #10823

If no regressions arise, payment will be issued on 2022-09-26. 🎊

[arielgreen]

@Santhosh-Sellavel @thesahindia @varshamb please check your Upwork inboxes

[Santhosh-Sellavel]

Thanks, @arielgreen!

[arielgreen]

Paid.