From df0bb414124063652f8a02b27b7dae1399c42c20 Mon Sep 17 00:00:00 2001 From: Mateusz Rajski Date: Fri, 21 Feb 2025 14:44:23 +0100 Subject: [PATCH] Do not redirect on desktop --- src/libs/actions/Welcome/index.ts | 4 +- .../BaseOnboardingEmployees.tsx | 48 +++++++++++-------- 2 files changed, 29 insertions(+), 23 deletions(-) diff --git a/src/libs/actions/Welcome/index.ts b/src/libs/actions/Welcome/index.ts index 3368315faa0e..572bbef08188 100644 --- a/src/libs/actions/Welcome/index.ts +++ b/src/libs/actions/Welcome/index.ts @@ -12,7 +12,7 @@ import type {OnboardingPurpose} from '@src/types/onyx'; import type Onboarding from '@src/types/onyx/Onboarding'; import type TryNewDot from '@src/types/onyx/TryNewDot'; import {isEmptyObject} from '@src/types/utils/EmptyObject'; -import * as OnboardingFlow from './OnboardingFlow'; +import {clearInitialPath} from './OnboardingFlow'; type OnboardingData = Onboarding | undefined; @@ -207,7 +207,7 @@ function resetAllChecks() { }); isLoadingReportData = true; isOnboardingInProgress = false; - OnboardingFlow.clearInitialPath(); + clearInitialPath(); } function setSelfTourViewed(shouldUpdateOnyxDataOnlyLocally = false) { diff --git a/src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx b/src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx index aa5e7acab8ce..59b385af41bc 100644 --- a/src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx +++ b/src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx @@ -13,9 +13,10 @@ import Text from '@components/Text'; import useLocalize from '@hooks/useLocalize'; import useResponsiveLayout from '@hooks/useResponsiveLayout'; import useThemeStyles from '@hooks/useThemeStyles'; +import getPlatform from '@libs/getPlatform'; import Navigation from '@libs/Navigation/Navigation'; import {isPaidGroupPolicy} from '@libs/PolicyUtils'; -import * as Link from '@userActions/Link'; +import {openOldDotLink} from '@userActions/Link'; import {createWorkspace, generatePolicyID} from '@userActions/Policy/Policy'; import {completeOnboarding} from '@userActions/Report'; import {setOnboardingAdminsChatReportID, setOnboardingCompanySize, setOnboardingPolicyID, switchToOldDotOnNonMicroCompanySize} from '@userActions/Welcome'; @@ -73,7 +74,10 @@ function BaseOnboardingEmployees({shouldUseNativeStyles, route}: BaseOnboardingE return; } setOnboardingCompanySize(selectedCompanySize); - switchToOldDotOnNonMicroCompanySize(selectedCompanySize); + + if (getPlatform() !== CONST.PLATFORM.DESKTOP) { + switchToOldDotOnNonMicroCompanySize(selectedCompanySize); // SHOULD BE DISABLED ON DESKTOP + } const shouldCreateWorkspace = !onboardingPolicyID && !paidGroupPolicy; @@ -94,26 +98,28 @@ function BaseOnboardingEmployees({shouldUseNativeStyles, route}: BaseOnboardingE return; } - // For other company sizes we want to complete onboarding here. - // At this point `onboardingPurposeSelected` should always exist as we set it in `BaseOnboardingPurpose`. - if (onboardingPurposeSelected) { - completeOnboarding( - onboardingPurposeSelected, - CONST.ONBOARDING_MESSAGES[onboardingPurposeSelected], - undefined, - undefined, - adminsChatReportID, - onboardingPolicyID, - undefined, - onboardingCompanySize, - ); - } + if (getPlatform() !== CONST.PLATFORM.DESKTOP) { + // For other company sizes we want to complete onboarding here. + // At this point `onboardingPurposeSelected` should always exist as we set it in `BaseOnboardingPurpose`. + if (onboardingPurposeSelected) { + completeOnboarding( + onboardingPurposeSelected, + CONST.ONBOARDING_MESSAGES[onboardingPurposeSelected], + undefined, + undefined, + adminsChatReportID, + onboardingPolicyID, + undefined, + onboardingCompanySize, + ); + } - if (NativeModules.HybridAppModule) { - NativeModules.HybridAppModule.closeReactNativeApp(false, true); - setRootStatusBarEnabled(false); - } else { - Link.openOldDotLink(CONST.OLDDOT_URLS.INBOX, true); + if (NativeModules.HybridAppModule) { + NativeModules.HybridAppModule.closeReactNativeApp(false, true); + setRootStatusBarEnabled(false); + } else { + openOldDotLink(CONST.OLDDOT_URLS.INBOX, true); // SHOULD BE DISABLED ON DESKTOP + } } }} pressOnEnter