Merge pull request #38758 from Expensify/hayata-fix-localization-key

roryabraham · OSBotify · commit 702d4f98c81d · 2024-03-21T19:13:10.000Z
Fix the check on the translated phrase (cherry picked from commit b5df48f)
diff --git a/src/libs/Localize/index.ts b/src/libs/Localize/index.ts
@@ -152,7 +152,7 @@ function translate<TKey extends TranslationPaths>(desiredLanguage: 'en' | 'es' |
     const languageAbbreviation = desiredLanguage.substring(0, 2) as 'en' | 'es';
 
     const translatedPhrase = getTranslatedPhrase(language, phraseKey, languageAbbreviation, ...phraseParameters);
-    if (translatedPhrase) {
+    if (translatedPhrase !== null && translatedPhrase !== undefined) {
         return translatedPhrase;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ function translate<TKey extends TranslationPaths>(desiredLanguage: 'en' \| 'es' \|`
`152`	`152`	`const languageAbbreviation = desiredLanguage.substring(0, 2) as 'en' \| 'es';`
`153`	`153`
`154`	`154`	`const translatedPhrase = getTranslatedPhrase(language, phraseKey, languageAbbreviation, ...phraseParameters);`
`155`		`- if (translatedPhrase) {`
	`155`	`+ if (translatedPhrase !== null && translatedPhrase !== undefined) {`
`156`	`156`	`return translatedPhrase;`
`157`	`157`	`}`
`158`	`158`