Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubKey based blocking #162

Closed
moshababo opened this issue Jun 27, 2018 · 3 comments
Closed

PubKey based blocking #162

moshababo opened this issue Jun 27, 2018 · 3 comments
Assignees
Labels
p2p Peer to peer networking P2 mid priority
Milestone

Comments

@moshababo
Copy link
Collaborator

moshababo commented Jun 27, 2018

  1. Add to handshake: exchange nodePubKey (done)

  2. When blocking a peer, we're doing it according to his ip address (without specifying the port, which is irrelevant). This means we can disconnect from him immediately, before handshaking, when he tries to reconnect. A support for blocking according to nodePubKey need to be added. This info will be known only after handshaking. The implementation need to take into consideration that one ip address could have multiple public keys, and vise versa.

@moshababo moshababo added the p2p Peer to peer networking label Jun 27, 2018
@moshababo moshababo changed the title Public key based blocking PubKey based blocking Jun 27, 2018
@kilrau
Copy link
Contributor

kilrau commented Jun 27, 2018

Yep, definitely needed. Important to prevent Sybil attacks since staked coins are PER PUBKEY.

@kilrau kilrau added this to the 1.0.0-alpha milestone Jun 27, 2018
@itsbalamurali
Copy link
Contributor

itsbalamurali commented Jun 27, 2018

@moshababo I meant this when I meant there should be a way to disconnect via public key.

@itsbalamurali itsbalamurali self-assigned this Jun 27, 2018
@moshababo
Copy link
Collaborator Author

moshababo commented Jun 28, 2018

Yes, I didn't thought it's important enough to implement it merely for the manual disconnection, but since we'll need it for automatic blocking anyway, we'll better make it work also for the gRPC call as you suggested.
Anyway, to implement this we'll need to do some changes in the way we're managing the peers/hosts list. Please be in touch with me before starting to implement it.

This task is not a top-priority now.

@moshababo moshababo added the P2 mid priority label Jun 28, 2018
@kilrau kilrau modified the milestones: 1.0.0-alpha.1, 1.0.0-alpha.2 Sep 6, 2018
@kilrau kilrau closed this as completed Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2p Peer to peer networking P2 mid priority
Projects
None yet
Development

No branches or pull requests

3 participants