You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When blocking a peer, we're doing it according to his ip address (without specifying the port, which is irrelevant). This means we can disconnect from him immediately, before handshaking, when he tries to reconnect. A support for blocking according to nodePubKey need to be added. This info will be known only after handshaking. The implementation need to take into consideration that one ip address could have multiple public keys, and vise versa.
The text was updated successfully, but these errors were encountered:
Yes, I didn't thought it's important enough to implement it merely for the manual disconnection, but since we'll need it for automatic blocking anyway, we'll better make it work also for the gRPC call as you suggested.
Anyway, to implement this we'll need to do some changes in the way we're managing the peers/hosts list. Please be in touch with me before starting to implement it.
Add to handshake: exchange
nodePubKey
(done)When blocking a peer, we're doing it according to his ip address (without specifying the port, which is irrelevant). This means we can disconnect from him immediately, before handshaking, when he tries to reconnect. A support for blocking according to
nodePubKey
need to be added. This info will be known only after handshaking. The implementation need to take into consideration that one ip address could have multiple public keys, and vise versa.The text was updated successfully, but these errors were encountered: