From bacd170c0e26d939369ef64e8c88ac11f31501bf Mon Sep 17 00:00:00 2001 From: benjaminneildavis Date: Fri, 12 Dec 2014 12:20:35 -0500 Subject: [PATCH] Wrapping in boolean if statement and cleaning up comments. --- js/checkbox.js | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/js/checkbox.js b/js/checkbox.js index df641ec3c..b1a175f4e 100644 --- a/js/checkbox.js +++ b/js/checkbox.js @@ -113,16 +113,14 @@ toggle: function(e) { //keep event from firing twice in Chrome if (!e || (e.target === e.originalEvent.target)) { - if(Boolean(e)){ - //stop bubbling, otherwise event fires twice in Firefox. - e.preventDefault(); - //make change event still fire (prevented by preventDefault) - // - } + this.state.checked = !this.state.checked; this._toggleCheckedState(); - this.$element.trigger('change', e); + + if(Boolean(e)){ + this.$element.trigger('change', e); + } } },