From 5c095503837f3c701e8556e2a5912db00a4d7026 Mon Sep 17 00:00:00 2001
From: Christopher McCulloh <cmcculloh@exacttarget.com>
Date: Wed, 14 Jun 2017 09:53:01 -0400
Subject: [PATCH] (GH1964) sets root tree element tabindex to -1 on tree item
 focus so that shift+tab will work

---
 js/tree.js                     | 20 ++++++++++++++++++++
 test/tree-tests/tab-indexes.js |  5 ++++-
 2 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/js/tree.js b/js/tree.js
index ba011d60d..1bf62fb09 100644
--- a/js/tree.js
+++ b/js/tree.js
@@ -522,6 +522,26 @@
 	// PRIVATE FUNCTIONS
 
 	var fixFocusability = function fixFocusability ($tree, $branch) {
+		/*
+		When tree initializes on page, the `<ul>` element should have tabindex=0 and all sub-elements should have
+		tabindex=-1. When focus leaves the tree, whatever the last focused on element was will keep the tabindex=0. The
+		tree itself will have a tabindex=-1. The reason for this is that if you are inside of the tree and press
+		shift+tab, it will try and focus on the tree you are already in, which will cause focus to shift immediately
+		back to the element you are already focused on. That will make it seem like the event is getting "Swallowed up"
+		by an aggressive event listener trap.
+
+		For this reason, only one element in the entire tree, including the tree itself, should ever have tabindex=0.
+		If somewhere down the line problems are being caused by this, the only further potential improvement I can
+		envision at this time is listening for the tree to lose focus and reseting the tabindexes of all children to -1
+		and setting the tabindex of the tree itself back to 0. This seems overly complicated with no benefit that I can
+		imagine at this time, so instead I am leaving the last focused element with the tabindex of 0, even upon blur of
+		the tree.
+
+		One benefit to leaving the last focused element in a tree with a tabindex=0 is that if you accidentally tab out
+		of the tree and then want to tab back in, you will be placed exactly where you left off instead of at the
+		beginning of the tree.
+		*/
+		$tree.attr('tabindex', -1);
 		$tree.find('li').attr('tabindex', -1);
 		if ($branch && $branch.length > 0) {
 			$branch.attr('tabindex', 0); // if tabindex is not set to 0 (or greater), node is not able to receive focus
diff --git a/test/tree-tests/tab-indexes.js b/test/tree-tests/tab-indexes.js
index 9963fc0df..2d56dfd73 100644
--- a/test/tree-tests/tab-indexes.js
+++ b/test/tree-tests/tab-indexes.js
@@ -10,7 +10,10 @@ define(function Module (require) {
 			QUnit.skip('are set to 1 for selected items', function loadTree (assert) {
 
 			});
-			QUnit.skip('are all set to -1 on blur', function loadTree (assert) {
+			QUnit.skip('are all set to -1 on new item selection', function loadTree (assert) {
+
+			});
+			QUnit.skip('root tree element is set to -1 on item selection', function loadTree (assert) {
 
 			});
 		});