Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Repeater: Row selection background color #56

Closed
mbeard opened this issue Nov 12, 2014 · 7 comments · Fixed by #63
Closed

Repeater: Row selection background color #56

mbeard opened this issue Nov 12, 2014 · 7 comments · Fixed by #63
Assignees
Milestone

Comments

@mbeard
Copy link
Contributor

mbeard commented Nov 12, 2014

The background color of a selected row should likely be consistent with the background color of other selected elements within our controls. For instance, the background color of a selected node in the Tree is #b9dff1

Since grid and tree are often paired together, these should be the same - I would use #b9dff1

@interactivellama
Copy link
Contributor

I looked through the current apps and found #d9eaf5 which I think clashes less with the hue of the blue link text and the brightness of the gray text.

#b9dff1
screenshot 2014-11-11 21 33 36

#d9eaf5
screenshot 2014-11-11 21 34 17

@mbeard mbeard added this to the 1.2.0 milestone Nov 12, 2014
@skipzero
Copy link
Contributor

Well, if use #d9eaf5, I'll have to change it in the tree as well. What would be the best approach here? I'm fine going with the latter.

@mbeard
Copy link
Contributor Author

mbeard commented Nov 12, 2014

I think #d9eaf5 is fine. I do agree, this should be the selected background across all controls (the repeater (selected row), tree (selected node), and datepicker (selected day).

For repeater, this should be applied to both the list view extension and the thumbnail view extension. For datepicker, this should be applied to the standalone datepicker control as well as within scheduler.

@skipzero
Copy link
Contributor

Alright I'll get on switch those out.

@interactivellama
Copy link
Contributor

Should probably be a variable, too. It might already be. Thanks Skip.

@skipzero
Copy link
Contributor

So the tree selected bg color is in MCTheme but the repeater bg color looks to be in fuel. Should I consolidate them both to theme?

@skipzero
Copy link
Contributor

Per @interactivellama, going to add the blue to MCTheme and change the selected color in Fuelux to a light gray. (#efefef) Will open an issue in Fuelux to take care of changing the color there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants