From fb280a77c26377cb50d87dec15c172f8822c2af9 Mon Sep 17 00:00:00 2001 From: DitwanP Date: Wed, 18 Sep 2024 11:48:44 -0700 Subject: [PATCH 1/9] chore(changelog): add deprecations type to lerna config --- lerna.json | 49 ++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/lerna.json b/lerna.json index 7c9e2c85009..a1eb201737e 100644 --- a/lerna.json +++ b/lerna.json @@ -1,7 +1,54 @@ { "$schema": "node_modules/lerna/schemas/lerna-schema.json", "version": "independent", - "changelogPreset": "conventionalcommits", + "changelogPreset": { + "name": "conventionalcommits", + "issueUrlFormat": "{{host}}/{{owner}}/{{repository}}/issues/{{id}}", + "commitUrlFormat": "{{host}}/{{owner}}/{{repository}}/commit/{{hash}}", + "issuePrefixes": ["#"], + "types": [ + { + "type": "feat", + "section": "Features" + }, + { + "type": "fix", + "section": "Bug Fixes" + }, + { + "type": "revert", + "section": "Reverts" + }, + { + "type": "perf", + "section": "Performance Improvements" + }, + { + "type": "deprecation", + "section": "Deprecations" + }, + { + "type": "chore", + "hidden": true + }, + { + "type": "docs", + "hidden": true + }, + { + "type": "style", + "hidden": true + }, + { + "type": "refactor", + "hidden": true + }, + { + "type": "test", + "hidden": true + } + ] + }, "command": { "version": { "conventionalCommits": true, From 018fd2ccdb09140e67b68a364381b30d5e69bb94 Mon Sep 17 00:00:00 2001 From: DitwanP Date: Wed, 18 Sep 2024 15:27:42 -0700 Subject: [PATCH 2/9] add deprecation type to changelog-sections of release-please config --- lerna.json | 22 ++-- .../calcite-components/src/components.d.ts | 100 ++++++++++++++++++ release-please-config.json | 15 +++ 3 files changed, 130 insertions(+), 7 deletions(-) diff --git a/lerna.json b/lerna.json index a1eb201737e..e643241b577 100644 --- a/lerna.json +++ b/lerna.json @@ -15,28 +15,28 @@ "type": "fix", "section": "Bug Fixes" }, - { - "type": "revert", - "section": "Reverts" - }, { "type": "perf", "section": "Performance Improvements" }, + { + "type": "revert", + "section": "Reverts" + }, { "type": "deprecation", "section": "Deprecations" }, { - "type": "chore", + "type": "docs", "hidden": true }, { - "type": "docs", + "type": "style", "hidden": true }, { - "type": "style", + "type": "chore", "hidden": true }, { @@ -46,6 +46,14 @@ { "type": "test", "hidden": true + }, + { + "type": "build", + "hidden": true + }, + { + "type": "ci", + "hidden": true } ] }, diff --git a/packages/calcite-components/src/components.d.ts b/packages/calcite-components/src/components.d.ts index bffc8ef3637..68d4f03e98e 100644 --- a/packages/calcite-components/src/components.d.ts +++ b/packages/calcite-components/src/components.d.ts @@ -9,91 +9,191 @@ import { Alignment, Appearance, CollapseDirection, FlipContext, IconType, Kind, import { RequestedItem } from "./components/accordion/interfaces"; import { IconNameOrString } from "./components/icon/interfaces"; import { RequestedItem as RequestedItem1 } from "./components/accordion-item/interfaces"; +import { ActionMessages } from "./components/action/assets/action/t9n"; import { FlipPlacement, LogicalPlacement, MenuPlacement, OverlayPositioning, ReferenceElement } from "./utils/floating-ui"; +import { ActionBarMessages } from "./components/action-bar/assets/action-bar/t9n"; import { Columns } from "./components/action-group/interfaces"; +import { ActionGroupMessages } from "./components/action-group/assets/action-group/t9n"; +import { ActionPadMessages } from "./components/action-pad/assets/action-pad/t9n"; import { AlertDuration, AlertQueue } from "./components/alert/interfaces"; import { NumberingSystem } from "./utils/locale"; +import { AlertMessages } from "./components/alert/assets/alert/t9n"; import { HeadingLevel } from "./components/functional/Heading"; +import { BlockMessages } from "./components/block/assets/block/t9n"; import { BlockSectionToggleDisplay } from "./components/block-section/interfaces"; +import { BlockSectionMessages } from "./components/block-section/assets/block-section/t9n"; import { ButtonAlignment, DropdownIconType } from "./components/button/interfaces"; +import { ButtonMessages } from "./components/button/assets/button/t9n"; +import { CardMessages } from "./components/card/assets/card/t9n"; import { ArrowType, AutoplayType } from "./components/carousel/interfaces"; +import { CarouselMessages } from "./components/carousel/assets/carousel/t9n"; import { MutableValidityState } from "./utils/form"; +import { ChipMessages } from "./components/chip/assets/chip/t9n"; import { ColorValue, InternalColor } from "./components/color-picker/interfaces"; import { Format } from "./components/color-picker/utils"; +import { ColorPickerMessages } from "./components/color-picker/assets/color-picker/t9n"; import { ComboboxChildElement, SelectionDisplay } from "./components/combobox/interfaces"; +import { ComboboxMessages } from "./components/combobox/assets/combobox/t9n"; +import { DatePickerMessages } from "./components/date-picker/assets/date-picker/t9n"; import { DateLocaleData } from "./components/date-picker/utils"; import { HoverRange } from "./utils/date"; +import { DialogMessages } from "./components/dialog/assets/dialog/t9n"; import { DialogPlacement } from "./components/dialog/interfaces"; import { RequestedItem as RequestedItem2 } from "./components/dropdown-group/interfaces"; import { ItemKeyboardEvent } from "./components/dropdown/interfaces"; +import { FilterMessages } from "./components/filter/assets/filter/t9n"; import { FlowItemLikeElement } from "./components/flow/interfaces"; +import { FlowItemMessages } from "./components/flow-item/assets/flow-item/t9n"; import { ColorStop, DataSeries } from "./components/graph/interfaces"; +import { HandleMessages } from "./components/handle/assets/handle/t9n"; import { HandleChange, HandleNudge } from "./components/handle/interfaces"; +import { InlineEditableMessages } from "./components/inline-editable/assets/inline-editable/t9n"; import { InputPlacement } from "./components/input/interfaces"; +import { InputMessages } from "./components/input/assets/input/t9n"; +import { InputDatePickerMessages } from "./components/input-date-picker/assets/input-date-picker/t9n"; +import { InputNumberMessages } from "./components/input-number/assets/input-number/t9n"; +import { InputTextMessages } from "./components/input-text/assets/input-text/t9n"; +import { InputTimePickerMessages } from "./components/input-time-picker/assets/input-time-picker/t9n"; +import { TimePickerMessages } from "./components/time-picker/assets/time-picker/t9n"; +import { InputTimeZoneMessages } from "./components/input-time-zone/assets/input-time-zone/t9n"; import { OffsetStyle, TimeZoneMode } from "./components/input-time-zone/interfaces"; import { ListDragDetail } from "./components/list/interfaces"; import { ItemData } from "./components/list-item/interfaces"; +import { ListMessages } from "./components/list/assets/list/t9n"; import { SelectionAppearance } from "./components/list/resources"; +import { ListItemMessages } from "./components/list-item/assets/list-item/t9n"; +import { MenuMessages } from "./components/menu/assets/menu/t9n"; +import { MenuItemMessages } from "./components/menu-item/assets/menu-item/t9n"; import { MenuItemCustomEvent } from "./components/menu-item/interfaces"; import { MeterFillType, MeterLabelType } from "./components/meter/interfaces"; +import { ModalMessages } from "./components/modal/assets/modal/t9n"; +import { NoticeMessages } from "./components/notice/assets/notice/t9n"; +import { PaginationMessages } from "./components/pagination/assets/pagination/t9n"; +import { PanelMessages } from "./components/panel/assets/panel/t9n"; import { ItemData as ItemData1, ListFocusId } from "./components/pick-list/shared-list-logic"; import { ICON_TYPES } from "./components/pick-list/resources"; +import { PickListItemMessages } from "./components/pick-list-item/assets/pick-list-item/t9n"; +import { PopoverMessages } from "./components/popover/assets/popover/t9n"; +import { RatingMessages } from "./components/rating/assets/rating/t9n"; +import { ScrimMessages } from "./components/scrim/assets/scrim/t9n"; import { DisplayMode } from "./components/sheet/interfaces"; import { DisplayMode as DisplayMode1 } from "./components/shell-panel/interfaces"; +import { ShellPanelMessages } from "./components/shell-panel/assets/shell-panel/t9n"; import { DragDetail } from "./utils/sortableComponent"; import { StepperItemChangeEventDetail, StepperItemEventDetail, StepperItemKeyEventDetail, StepperLayout } from "./components/stepper/interfaces"; +import { StepperMessages } from "./components/stepper/assets/stepper/t9n"; +import { StepperItemMessages } from "./components/stepper-item/assets/stepper-item/t9n"; import { TabID, TabLayout, TabPosition } from "./components/tabs/interfaces"; +import { TabNavMessages } from "./components/tab-nav/assets/tab-nav/t9n"; import { Element } from "@stencil/core"; import { TabChangeEventDetail, TabCloseEventDetail } from "./components/tab/interfaces"; +import { TabTitleMessages } from "./components/tab-title/assets/tab-title/t9n"; import { RowType, TableInteractionMode, TableLayout, TableRowFocusEvent, TableSelectionDisplay } from "./components/table/interfaces"; +import { TableMessages } from "./components/table/assets/table/t9n"; +import { TableCellMessages } from "./components/table-cell/assets/table-cell/t9n"; +import { TableHeaderMessages } from "./components/table-header/assets/table-header/t9n"; +import { TextAreaMessages } from "./components/text-area/assets/text-area/t9n"; import { TileSelectType } from "./components/tile-select/interfaces"; import { TileSelectGroupLayout } from "./components/tile-select-group/interfaces"; +import { TipMessages } from "./components/tip/assets/tip/t9n"; +import { TipManagerMessages } from "./components/tip-manager/assets/tip-manager/t9n"; import { TreeItemSelectDetail } from "./components/tree-item/interfaces"; +import { ValueListMessages } from "./components/value-list/assets/value-list/t9n"; import { ListItemAndHandle } from "./components/value-list-item/interfaces"; export { Alignment, Appearance, CollapseDirection, FlipContext, IconType, Kind, Layout, LogicalFlowPosition, Position, Scale, SelectionAppearance as SelectionAppearance1, SelectionMode, Status, Width } from "./components/interfaces"; export { RequestedItem } from "./components/accordion/interfaces"; export { IconNameOrString } from "./components/icon/interfaces"; export { RequestedItem as RequestedItem1 } from "./components/accordion-item/interfaces"; +export { ActionMessages } from "./components/action/assets/action/t9n"; export { FlipPlacement, LogicalPlacement, MenuPlacement, OverlayPositioning, ReferenceElement } from "./utils/floating-ui"; +export { ActionBarMessages } from "./components/action-bar/assets/action-bar/t9n"; export { Columns } from "./components/action-group/interfaces"; +export { ActionGroupMessages } from "./components/action-group/assets/action-group/t9n"; +export { ActionPadMessages } from "./components/action-pad/assets/action-pad/t9n"; export { AlertDuration, AlertQueue } from "./components/alert/interfaces"; export { NumberingSystem } from "./utils/locale"; +export { AlertMessages } from "./components/alert/assets/alert/t9n"; export { HeadingLevel } from "./components/functional/Heading"; +export { BlockMessages } from "./components/block/assets/block/t9n"; export { BlockSectionToggleDisplay } from "./components/block-section/interfaces"; +export { BlockSectionMessages } from "./components/block-section/assets/block-section/t9n"; export { ButtonAlignment, DropdownIconType } from "./components/button/interfaces"; +export { ButtonMessages } from "./components/button/assets/button/t9n"; +export { CardMessages } from "./components/card/assets/card/t9n"; export { ArrowType, AutoplayType } from "./components/carousel/interfaces"; +export { CarouselMessages } from "./components/carousel/assets/carousel/t9n"; export { MutableValidityState } from "./utils/form"; +export { ChipMessages } from "./components/chip/assets/chip/t9n"; export { ColorValue, InternalColor } from "./components/color-picker/interfaces"; export { Format } from "./components/color-picker/utils"; +export { ColorPickerMessages } from "./components/color-picker/assets/color-picker/t9n"; export { ComboboxChildElement, SelectionDisplay } from "./components/combobox/interfaces"; +export { ComboboxMessages } from "./components/combobox/assets/combobox/t9n"; +export { DatePickerMessages } from "./components/date-picker/assets/date-picker/t9n"; export { DateLocaleData } from "./components/date-picker/utils"; export { HoverRange } from "./utils/date"; +export { DialogMessages } from "./components/dialog/assets/dialog/t9n"; export { DialogPlacement } from "./components/dialog/interfaces"; export { RequestedItem as RequestedItem2 } from "./components/dropdown-group/interfaces"; export { ItemKeyboardEvent } from "./components/dropdown/interfaces"; +export { FilterMessages } from "./components/filter/assets/filter/t9n"; export { FlowItemLikeElement } from "./components/flow/interfaces"; +export { FlowItemMessages } from "./components/flow-item/assets/flow-item/t9n"; export { ColorStop, DataSeries } from "./components/graph/interfaces"; +export { HandleMessages } from "./components/handle/assets/handle/t9n"; export { HandleChange, HandleNudge } from "./components/handle/interfaces"; +export { InlineEditableMessages } from "./components/inline-editable/assets/inline-editable/t9n"; export { InputPlacement } from "./components/input/interfaces"; +export { InputMessages } from "./components/input/assets/input/t9n"; +export { InputDatePickerMessages } from "./components/input-date-picker/assets/input-date-picker/t9n"; +export { InputNumberMessages } from "./components/input-number/assets/input-number/t9n"; +export { InputTextMessages } from "./components/input-text/assets/input-text/t9n"; +export { InputTimePickerMessages } from "./components/input-time-picker/assets/input-time-picker/t9n"; +export { TimePickerMessages } from "./components/time-picker/assets/time-picker/t9n"; +export { InputTimeZoneMessages } from "./components/input-time-zone/assets/input-time-zone/t9n"; export { OffsetStyle, TimeZoneMode } from "./components/input-time-zone/interfaces"; export { ListDragDetail } from "./components/list/interfaces"; export { ItemData } from "./components/list-item/interfaces"; +export { ListMessages } from "./components/list/assets/list/t9n"; export { SelectionAppearance } from "./components/list/resources"; +export { ListItemMessages } from "./components/list-item/assets/list-item/t9n"; +export { MenuMessages } from "./components/menu/assets/menu/t9n"; +export { MenuItemMessages } from "./components/menu-item/assets/menu-item/t9n"; export { MenuItemCustomEvent } from "./components/menu-item/interfaces"; export { MeterFillType, MeterLabelType } from "./components/meter/interfaces"; +export { ModalMessages } from "./components/modal/assets/modal/t9n"; +export { NoticeMessages } from "./components/notice/assets/notice/t9n"; +export { PaginationMessages } from "./components/pagination/assets/pagination/t9n"; +export { PanelMessages } from "./components/panel/assets/panel/t9n"; export { ItemData as ItemData1, ListFocusId } from "./components/pick-list/shared-list-logic"; export { ICON_TYPES } from "./components/pick-list/resources"; +export { PickListItemMessages } from "./components/pick-list-item/assets/pick-list-item/t9n"; +export { PopoverMessages } from "./components/popover/assets/popover/t9n"; +export { RatingMessages } from "./components/rating/assets/rating/t9n"; +export { ScrimMessages } from "./components/scrim/assets/scrim/t9n"; export { DisplayMode } from "./components/sheet/interfaces"; export { DisplayMode as DisplayMode1 } from "./components/shell-panel/interfaces"; +export { ShellPanelMessages } from "./components/shell-panel/assets/shell-panel/t9n"; export { DragDetail } from "./utils/sortableComponent"; export { StepperItemChangeEventDetail, StepperItemEventDetail, StepperItemKeyEventDetail, StepperLayout } from "./components/stepper/interfaces"; +export { StepperMessages } from "./components/stepper/assets/stepper/t9n"; +export { StepperItemMessages } from "./components/stepper-item/assets/stepper-item/t9n"; export { TabID, TabLayout, TabPosition } from "./components/tabs/interfaces"; +export { TabNavMessages } from "./components/tab-nav/assets/tab-nav/t9n"; export { Element } from "@stencil/core"; export { TabChangeEventDetail, TabCloseEventDetail } from "./components/tab/interfaces"; +export { TabTitleMessages } from "./components/tab-title/assets/tab-title/t9n"; export { RowType, TableInteractionMode, TableLayout, TableRowFocusEvent, TableSelectionDisplay } from "./components/table/interfaces"; +export { TableMessages } from "./components/table/assets/table/t9n"; +export { TableCellMessages } from "./components/table-cell/assets/table-cell/t9n"; +export { TableHeaderMessages } from "./components/table-header/assets/table-header/t9n"; +export { TextAreaMessages } from "./components/text-area/assets/text-area/t9n"; export { TileSelectType } from "./components/tile-select/interfaces"; export { TileSelectGroupLayout } from "./components/tile-select-group/interfaces"; +export { TipMessages } from "./components/tip/assets/tip/t9n"; +export { TipManagerMessages } from "./components/tip-manager/assets/tip-manager/t9n"; export { TreeItemSelectDetail } from "./components/tree-item/interfaces"; +export { ValueListMessages } from "./components/value-list/assets/value-list/t9n"; export { ListItemAndHandle } from "./components/value-list-item/interfaces"; export namespace Components { interface CalciteAccordion { diff --git a/release-please-config.json b/release-please-config.json index 9a78a7c49df..f757114b3e6 100644 --- a/release-please-config.json +++ b/release-please-config.json @@ -4,6 +4,21 @@ "tag-separator": "@", "draft-pull-request": true, "include-v-in-tag": false, + "changelog-sections": [ + { "type": "feat", "section": "Features" }, + { "type": "feature", "section": "Features" }, + { "type": "fix", "section": "Bug Fixes" }, + { "type": "perf", "section": "Performance Improvements" }, + { "type": "revert", "section": "Reverts" }, + { "type": "deprecation", "section": "Deprecations" }, + { "type": "docs", "section": "Documentation", "hidden": true }, + { "type": "style", "section": "Styles", "hidden": true }, + { "type": "chore", "section": "Miscellaneous Chores", "hidden": true }, + { "type": "refactor", "section": "Code Refactoring", "hidden": true }, + { "type": "test", "section": "Tests", "hidden": true }, + { "type": "build", "section": "Build System", "hidden": true }, + { "type": "ci", "section": "Continuous Integration", "hidden": true } + ], "packages": { "packages/calcite-components": { "component": "@esri/calcite-components", From 37fcc1fc66537c0d4da3997ef1d382f4f16c367f Mon Sep 17 00:00:00 2001 From: DitwanP Date: Wed, 18 Sep 2024 17:35:34 -0700 Subject: [PATCH 3/9] parody release-please types in lerna config --- lerna.json | 61 ++++++++++++------------------------------------------ 1 file changed, 13 insertions(+), 48 deletions(-) diff --git a/lerna.json b/lerna.json index e643241b577..bae67e3516e 100644 --- a/lerna.json +++ b/lerna.json @@ -7,54 +7,19 @@ "commitUrlFormat": "{{host}}/{{owner}}/{{repository}}/commit/{{hash}}", "issuePrefixes": ["#"], "types": [ - { - "type": "feat", - "section": "Features" - }, - { - "type": "fix", - "section": "Bug Fixes" - }, - { - "type": "perf", - "section": "Performance Improvements" - }, - { - "type": "revert", - "section": "Reverts" - }, - { - "type": "deprecation", - "section": "Deprecations" - }, - { - "type": "docs", - "hidden": true - }, - { - "type": "style", - "hidden": true - }, - { - "type": "chore", - "hidden": true - }, - { - "type": "refactor", - "hidden": true - }, - { - "type": "test", - "hidden": true - }, - { - "type": "build", - "hidden": true - }, - { - "type": "ci", - "hidden": true - } + { "type": "feat", "section": "Features" }, + { "type": "feature", "section": "Features" }, + { "type": "fix", "section": "Bug Fixes" }, + { "type": "perf", "section": "Performance Improvements" }, + { "type": "revert", "section": "Reverts" }, + { "type": "deprecation", "section": "Deprecations" }, + { "type": "docs", "section": "Documentation", "hidden": true }, + { "type": "style", "section": "Styles", "hidden": true }, + { "type": "chore", "section": "Miscellaneous Chores", "hidden": true }, + { "type": "refactor", "section": "Code Refactoring", "hidden": true }, + { "type": "test", "section": "Tests", "hidden": true }, + { "type": "build", "section": "Build System", "hidden": true }, + { "type": "ci", "section": "Continuous Integration", "hidden": true } ] }, "command": { From 20c4f32f9d9c18065f22bbe2621603f4932db99c Mon Sep 17 00:00:00 2001 From: DitwanP Date: Thu, 19 Sep 2024 11:33:21 -0700 Subject: [PATCH 4/9] cleanup --- lerna.json | 3 --- 1 file changed, 3 deletions(-) diff --git a/lerna.json b/lerna.json index bae67e3516e..4609ea2ac4f 100644 --- a/lerna.json +++ b/lerna.json @@ -3,9 +3,6 @@ "version": "independent", "changelogPreset": { "name": "conventionalcommits", - "issueUrlFormat": "{{host}}/{{owner}}/{{repository}}/issues/{{id}}", - "commitUrlFormat": "{{host}}/{{owner}}/{{repository}}/commit/{{hash}}", - "issuePrefixes": ["#"], "types": [ { "type": "feat", "section": "Features" }, { "type": "feature", "section": "Features" }, From d8335b2268cc3706b06d60e4aa004b0617840939 Mon Sep 17 00:00:00 2001 From: DitwanP Date: Mon, 23 Sep 2024 11:32:13 -0700 Subject: [PATCH 5/9] feedback changes --- lerna.json | 3 +-- release-please-config.json | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lerna.json b/lerna.json index 4609ea2ac4f..aefcb5e48e2 100644 --- a/lerna.json +++ b/lerna.json @@ -5,11 +5,10 @@ "name": "conventionalcommits", "types": [ { "type": "feat", "section": "Features" }, - { "type": "feature", "section": "Features" }, { "type": "fix", "section": "Bug Fixes" }, { "type": "perf", "section": "Performance Improvements" }, { "type": "revert", "section": "Reverts" }, - { "type": "deprecation", "section": "Deprecations" }, + { "type": "deprecate", "section": "Deprecations" }, { "type": "docs", "section": "Documentation", "hidden": true }, { "type": "style", "section": "Styles", "hidden": true }, { "type": "chore", "section": "Miscellaneous Chores", "hidden": true }, diff --git a/release-please-config.json b/release-please-config.json index f757114b3e6..2cba1466efa 100644 --- a/release-please-config.json +++ b/release-please-config.json @@ -6,11 +6,10 @@ "include-v-in-tag": false, "changelog-sections": [ { "type": "feat", "section": "Features" }, - { "type": "feature", "section": "Features" }, { "type": "fix", "section": "Bug Fixes" }, { "type": "perf", "section": "Performance Improvements" }, { "type": "revert", "section": "Reverts" }, - { "type": "deprecation", "section": "Deprecations" }, + { "type": "deprecate", "section": "Deprecations" }, { "type": "docs", "section": "Documentation", "hidden": true }, { "type": "style", "section": "Styles", "hidden": true }, { "type": "chore", "section": "Miscellaneous Chores", "hidden": true }, From c1ee6ca01d3c3cfcbdc3263a0937739e5e8628f0 Mon Sep 17 00:00:00 2001 From: DitwanP Date: Mon, 23 Sep 2024 14:57:17 -0700 Subject: [PATCH 6/9] hide reverts from changelog --- lerna.json | 2 +- release-please-config.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lerna.json b/lerna.json index aefcb5e48e2..2921cfb7b34 100644 --- a/lerna.json +++ b/lerna.json @@ -7,7 +7,7 @@ { "type": "feat", "section": "Features" }, { "type": "fix", "section": "Bug Fixes" }, { "type": "perf", "section": "Performance Improvements" }, - { "type": "revert", "section": "Reverts" }, + { "type": "revert", "section": "Reverts", "hidden": true }, { "type": "deprecate", "section": "Deprecations" }, { "type": "docs", "section": "Documentation", "hidden": true }, { "type": "style", "section": "Styles", "hidden": true }, diff --git a/release-please-config.json b/release-please-config.json index 2cba1466efa..c74072f6a59 100644 --- a/release-please-config.json +++ b/release-please-config.json @@ -8,7 +8,7 @@ { "type": "feat", "section": "Features" }, { "type": "fix", "section": "Bug Fixes" }, { "type": "perf", "section": "Performance Improvements" }, - { "type": "revert", "section": "Reverts" }, + { "type": "revert", "section": "Reverts", "hidden": true }, { "type": "deprecate", "section": "Deprecations" }, { "type": "docs", "section": "Documentation", "hidden": true }, { "type": "style", "section": "Styles", "hidden": true }, From 0a97cd46fcda2177bf01cd739a53a1bb2ae29d6e Mon Sep 17 00:00:00 2001 From: DitwanP Date: Wed, 25 Sep 2024 13:36:06 -0700 Subject: [PATCH 7/9] feedback changes --- CONTRIBUTING.md | 1 + lerna.json | 2 +- release-please-config.json | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6293266be1e..d104b7edc0c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -236,6 +236,7 @@ Contributions must adhere to **one** of the following conventions: - **`refactor`**: A change that neither fixes a bug or adds a feature ๐Ÿ” - **`revert`**: Reverts a previous commit โ†ช๏ธ - **`test`**: Improves test coverage in updating a test or adding a new, or missing test ๐Ÿงช +- **`deprecate-docs`**: Documentation only changes for a deprecation ๐Ÿ‘Ž ### Scope of change diff --git a/lerna.json b/lerna.json index 2921cfb7b34..1c12b77222d 100644 --- a/lerna.json +++ b/lerna.json @@ -8,7 +8,7 @@ { "type": "fix", "section": "Bug Fixes" }, { "type": "perf", "section": "Performance Improvements" }, { "type": "revert", "section": "Reverts", "hidden": true }, - { "type": "deprecate", "section": "Deprecations" }, + { "type": "deprecate-docs", "section": "Deprecations" }, { "type": "docs", "section": "Documentation", "hidden": true }, { "type": "style", "section": "Styles", "hidden": true }, { "type": "chore", "section": "Miscellaneous Chores", "hidden": true }, diff --git a/release-please-config.json b/release-please-config.json index c74072f6a59..15efeca04c5 100644 --- a/release-please-config.json +++ b/release-please-config.json @@ -9,7 +9,7 @@ { "type": "fix", "section": "Bug Fixes" }, { "type": "perf", "section": "Performance Improvements" }, { "type": "revert", "section": "Reverts", "hidden": true }, - { "type": "deprecate", "section": "Deprecations" }, + { "type": "deprecate-docs", "section": "Deprecations" }, { "type": "docs", "section": "Documentation", "hidden": true }, { "type": "style", "section": "Styles", "hidden": true }, { "type": "chore", "section": "Miscellaneous Chores", "hidden": true }, From 6f8005d49747e74d41fa0f9c8c0289fb532425fd Mon Sep 17 00:00:00 2001 From: DitwanP Date: Thu, 26 Sep 2024 12:51:23 -0700 Subject: [PATCH 8/9] feedback changes --- CONTRIBUTING.md | 2 +- lerna.json | 17 ----------------- release-please-config.json | 2 +- 3 files changed, 2 insertions(+), 19 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d104b7edc0c..2c938123c00 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -236,7 +236,7 @@ Contributions must adhere to **one** of the following conventions: - **`refactor`**: A change that neither fixes a bug or adds a feature ๐Ÿ” - **`revert`**: Reverts a previous commit โ†ช๏ธ - **`test`**: Improves test coverage in updating a test or adding a new, or missing test ๐Ÿงช -- **`deprecate-docs`**: Documentation only changes for a deprecation ๐Ÿ‘Ž +- **`deprecate`**: Documentation only changes for a deprecation ๐Ÿ‘Ž ### Scope of change diff --git a/lerna.json b/lerna.json index 1c12b77222d..f4397e3b687 100644 --- a/lerna.json +++ b/lerna.json @@ -1,23 +1,6 @@ { "$schema": "node_modules/lerna/schemas/lerna-schema.json", "version": "independent", - "changelogPreset": { - "name": "conventionalcommits", - "types": [ - { "type": "feat", "section": "Features" }, - { "type": "fix", "section": "Bug Fixes" }, - { "type": "perf", "section": "Performance Improvements" }, - { "type": "revert", "section": "Reverts", "hidden": true }, - { "type": "deprecate-docs", "section": "Deprecations" }, - { "type": "docs", "section": "Documentation", "hidden": true }, - { "type": "style", "section": "Styles", "hidden": true }, - { "type": "chore", "section": "Miscellaneous Chores", "hidden": true }, - { "type": "refactor", "section": "Code Refactoring", "hidden": true }, - { "type": "test", "section": "Tests", "hidden": true }, - { "type": "build", "section": "Build System", "hidden": true }, - { "type": "ci", "section": "Continuous Integration", "hidden": true } - ] - }, "command": { "version": { "conventionalCommits": true, diff --git a/release-please-config.json b/release-please-config.json index 15efeca04c5..c74072f6a59 100644 --- a/release-please-config.json +++ b/release-please-config.json @@ -9,7 +9,7 @@ { "type": "fix", "section": "Bug Fixes" }, { "type": "perf", "section": "Performance Improvements" }, { "type": "revert", "section": "Reverts", "hidden": true }, - { "type": "deprecate-docs", "section": "Deprecations" }, + { "type": "deprecate", "section": "Deprecations" }, { "type": "docs", "section": "Documentation", "hidden": true }, { "type": "style", "section": "Styles", "hidden": true }, { "type": "chore", "section": "Miscellaneous Chores", "hidden": true }, From 44aa52978ec37744be7609ac42b55e23a4e2dadd Mon Sep 17 00:00:00 2001 From: DitwanP Date: Thu, 26 Sep 2024 12:52:48 -0700 Subject: [PATCH 9/9] add back missing lerna config option --- lerna.json | 1 + 1 file changed, 1 insertion(+) diff --git a/lerna.json b/lerna.json index f4397e3b687..7c9e2c85009 100644 --- a/lerna.json +++ b/lerna.json @@ -1,6 +1,7 @@ { "$schema": "node_modules/lerna/schemas/lerna-schema.json", "version": "independent", + "changelogPreset": "conventionalcommits", "command": { "version": { "conventionalCommits": true,