Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tokens Epic] Restore Input corner-radius behavior #9083

Closed
1 of 5 tasks
Tracked by #7180
macandcheese opened this issue Apr 8, 2024 · 1 comment
Closed
1 of 5 tasks
Tracked by #7180

[Tokens Epic] Restore Input corner-radius behavior #9083

macandcheese opened this issue Apr 8, 2024 · 1 comment
Labels
calcite-components Issues specific to the @esri/calcite-components package. design-tokens Issues requiring design tokens. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library refactor Issues tied to code that needs to be significantly reworked.

Comments

@macandcheese
Copy link
Contributor

Description

In #7180 (in progress) - some of the Input corner-radius behavior was lost. It was working at the time of introduction into the epic: #8767 (comment)

Proposed Advantages

The component should behave as it did when introduced.

Which Component

Input (and any Input related components)

Relevant Info

It was functioning as-expected when initially merged in to #7180, so it was likely a merge conflict or other epic-related change.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@macandcheese macandcheese added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 8, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Apr 8, 2024
@macandcheese macandcheese added the design-tokens Issues requiring design tokens. label Jul 10, 2024
@geospatialem geospatialem mentioned this issue Sep 3, 2024
Open
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Sep 3, 2024
@macandcheese macandcheese removed 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Nov 21, 2024
@macandcheese
Copy link
Contributor Author

Addressed by #10820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
calcite-components Issues specific to the @esri/calcite-components package. design-tokens Issues requiring design tokens. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@macandcheese @geospatialem