Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Input Date Picker] Buggy experience in range when start date populated #8557

Closed
2 of 6 tasks
macandcheese opened this issue Jan 4, 2024 · 3 comments
Closed
2 of 6 tasks
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Jan 4, 2024

Check existing issues

Actual Behavior

Currently, when the start portion of a range is populated, there are some strange behaviors as a user interacting with the component:

Screen.Recording.2024-01-04.at.11.33.15.AM.mov

1 - The month in the shown calendar will change to the "current month" when the start value of a range is set and a user hovers over the start dropdown.
2 - A user selecting a date from the start range while the end is not populated, will set the end, not override the start

Expected Behavior

I would not expect the month in the start dropdown to change to the current month while hovering.
I would also expect the user interaction with the start date to override the start date, not set the end date - this ux needs to be supported to allow a user to change their start date before selecting an end date.

Note - When used with proximity-selection-disabled the hover-over-start-month-changing-to-current does NOT occur, but the behavior to change the start date without setting an end date is not supported still.

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/vYPLrMV?editors=1000

Reproduction Steps

  1. Open Codepen
  2. Notice the start date is populated
  3. Interact with the start date field to open the dropdown
  4. Begin to hover over the date grid, and notice the switch to the current month, not the populated date.
  5. Select a date.
  6. Notice the selection populates the end date - and does not override the already populated start date

Reproduction Version

2.1

Relevant Info

No response

Regression?

No response

Priority impact

p1 - need for current milestone

Impact

A few aspects here - the "hover to current month" is IMO a serious bug - the "populates end date and not override start date" is also an unexpected UX.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)

@macandcheese macandcheese added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Jan 4, 2024
@github-actions github-actions bot added impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. labels Jan 4, 2024
@dhagens
Copy link

dhagens commented Jan 4, 2024

This is a showstopper for our team using the picker with the range property. Mostly our end date is set to null and we only want to modify the start date. We are unable to achieve this workflow using the range property. We ended up going with two separate date pickers to achieve this.

@geospatialem geospatialem added estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Feb 7, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 3, 2024
@geospatialem geospatialem added this to the 2024-08-27 - Aug Release milestone Apr 3, 2024
@geospatialem geospatialem added the spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. label Jul 29, 2024
@geospatialem
Copy link
Member

Spike to determine if the enhancements of #8402 fulfill the above, and if not to determine next steps and priority for inclusion in October or beyond.

@anveshmekala anveshmekala self-assigned this Oct 7, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Dec 2, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 13, 2025
@geospatialem
Copy link
Member

Spike to determine if the enhancements of #8402 fulfill the above, and if not to determine next steps and priority for inclusion in October or beyond.

Verified with the input-date-picker UI/UX improvements in #8402 with https://codepen.io/geospatialem/pen/JoPvWEK in 3.0.0-next.96 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.
Projects
None yet
Development

No branches or pull requests

4 participants