Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[calcite-color-picker] add section for suggested colors #748

Open
jcfranco opened this issue Jul 22, 2020 · 17 comments
Open

[calcite-color-picker] add section for suggested colors #748

jcfranco opened this issue Jul 22, 2020 · 17 comments
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - md Medium design effort; 5-10 days of design work p - medium Issue is non core or affecting less that 60% of people using the library
Milestone

Comments

@jcfranco
Copy link
Member

The color picker has a section for storing colors, but it would be nice to add a special section for groups of color suggestions. The color picker from Chrome dev tools has a nice experience for this:

cdt-cp

The new Map Viewer has a concept of suggested colors that could leverage this as well.

Screen Shot 2020-07-22 at 8 22 08 AM

@jcfranco jcfranco added the enhancement Issues tied to a new feature or request. label Jul 22, 2020
@jcfranco jcfranco added this to the 🔨 v1-beta.34 milestone Jul 22, 2020
@macandcheese
Copy link
Contributor

Is above MVB example tied to a picker? Maybe allowing a calcite-color-swatch item / set to be used anywhere and placed in accordion panes could be a useful implementation as well.

@jcfranco
Copy link
Member Author

It's disconnected, but there's a 'color picker' in the collapsed section below.

Maybe allowing a calcite-color-swatch item / set to be used anywhere and placed in accordion panes could be a useful implementation as well.

This could work for simple color selection use cases, but there's no component at the moment for that.

@jcfranco jcfranco changed the title [color-picker] add section for suggested colors [calcite-color] add section for suggested colors Jul 23, 2020
@jcfranco
Copy link
Member Author

There's been interest in adding multiple sections of suggested colors (e.g., accessible, basemap colors), so this is something the design would need to take into consideration.

@macandcheese macandcheese removed this from the 📦 v1-beta.34 milestone Jul 29, 2020
@jcfranco jcfranco modified the milestones: v1.0.0-beta.46, v1.0.0-beta.45 Nov 10, 2020
@samanthahunter
Copy link

+1 for this enhancement

Our customers would like quick access to their site's theme colors while editing it, set it once and reuse everywhere. Would it be possible to provide the 'theme' colors as the default options in the saved colors area?

One pattern I saw in the webflow editor was 'global colors' had a triangle on them. So we can combine 'theme' colors with 'saved' colors in the same area - yet theme colors would not be editable/removable from the picker.

Global-colors-have-triangle

@samanthahunter
Copy link

Per @macandcheese idea, instead of combining 'theme' and 'saved' colors, could also use an accordion for swatch groups (in our case the theme colors) under the 'saved' colors area - which could also be a knob in the component to turn on/off.

@macandcheese
Copy link
Contributor

I think there's value in providing these "Swatch groups" outside of the Color Picker component itself. There may be times where these are used as the sole method of picking color (choose one from set of many), so let's make sure it's able to stand on its own (whether that's a swatch group / swatch component or otherwise), in addition to alongside the Color Picker.

This was an example from awhile ago of a few color swatch groups (in this case adjacent to a color picker, but it is easy to imagine just having the groups themselves as a method of entry) : https://codesandbox.io/s/calcite-color-picker-swatch-group-example-in-popover-l6qbu7

@zaramatheson
Copy link

Commenting on behalf of Russ:

  • Users a requesting the color picking include a set of standard colors the mirrors Pro selection.
  • Time frame would be for the R01 2024
  • Prio - Must. We have had multiple users request a standard color picker selection in MV. This would be used inside symbol styler, label styling, background color for example.
  • Sample image of the Pro ArcGIS Color picker that users reference.

image

@macandcheese
Copy link
Contributor

macandcheese commented Aug 1, 2023

I think many of these use cases speak to making the color swatch component public and adding a swatch group that can handle selection. These are definitely valid within a Color Picker but are valid on their own as well outside that context.

@zaramatheson the above screenshot can be achieved with current components if needed more immediately for a product feature.

In a world where those components exist, we could look at having a "swatch-group" slot within Color Picker to accept one or multiple Swatch Groups of recommended / pre-determined colors.

@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Aug 19, 2023
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label May 27, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

This issue has been automatically closed due to inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2024
@macandcheese macandcheese reopened this Jun 3, 2024
@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Jun 7, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jul 9, 2024
@geospatialem geospatialem removed the Stale Issues or pull requests that have not had recent activity. label Jul 9, 2024
@ellenupp
Copy link

+1 for Dashboards. We are interested in offering groups of predefined colors in the color picker, for example a set of theme colors or data point colors.

cc @allyshah

@ashetland ashetland added design Issues that need design consultation prior to development. needs triage Planning workflow - pending design/dev review. labels Aug 9, 2024
@ashetland ashetland removed this from the Freezer milestone Aug 9, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Sep 10, 2024
@geospatialem geospatialem removed the Stale Issues or pull requests that have not had recent activity. label Sep 10, 2024
@ashetland ashetland added p - medium Issue is non core or affecting less that 60% of people using the library estimate - design - lg Large design effort; 10-20 days of design work estimate - design - md Medium design effort; 5-10 days of design work blocked This issue is blocked by another issue. and removed estimate - design - lg Large design effort; 10-20 days of design work needs triage Planning workflow - pending design/dev review. labels Sep 12, 2024
@ashetland ashetland added this to the Stalled milestone Sep 12, 2024
@ashetland ashetland added the 0 - new New issues that need assignment. label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - design - md Medium design effort; 5-10 days of design work p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Development

No branches or pull requests