Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Input Date Picker] Start/End dates don't adjust initially when animations are reduced/disabled #6800

Closed
geospatialem opened this issue Apr 17, 2023 · 2 comments
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-datepicker Issues that pertain to the calcite-date-picker component estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library regression Issues that are caused by changes in a release, but were working before that.

Comments

@geospatialem
Copy link
Member

geospatialem commented Apr 17, 2023

Actual Behavior

Input Date Picker start/end dates don't adjust initially when:

  • Windows animations are disabled (Chrome, FF, Edge browsers), and
  • Mac's animations are reduced (Chrome, FF browsers)

input-date-picker-animation-bug

cc Created from an internal request (151) @jlias-devtester and #6410

Expected Behavior

When users have reduced motion, they should have similar experiences with input-date-picker changed values on initialization.

Reproduction Sample

https://codepen.io/geospatialem/pen/XWPOPaq

Reproduction Steps

  1. Disable animations (Windows) or enable reduced animations (Mac)
  2. Open the sample in either:
    • Windows: Chrome, FF, Edge, or
    • Mac: Chrome, FF
  3. Open the modal by selecting the "Open modal" button
  4. Try to modify the date-picker's start or end date.
  5. Observe the initial setting does not alter
  6. Try to modify the start or end date again.
  7. Observe the change works.
  8. Enable animations (Windows) or disable reduced animations (Mac)
  9. Repeat steps 2-6, and observe all changes are reflected as-expected

Reproduction Version

1.1.0

Relevant Info

  • Windows - all browsers (Chrome, FF, Edge)
  • Mac - Chrome and FF browsers (does not impact Safari)

Regression?

1.0.8

Priority impact

p4 - not time sensitive

Impact

Seems relatively low, but looks to be a regression - works as-expected in 1.0.8, and is presented in 1.1.0.

Possibly related to dfcaa22, if the animation fix includes input-date-picker? cc @jcfranco

Esri team

ArcGIS Online

@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - low Issue is non core or affecting less that 10% of people using the library 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. regression Issues that are caused by changes in a release, but were working before that. labels Apr 17, 2023
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Apr 17, 2023
@geospatialem geospatialem added c-datepicker Issues that pertain to the calcite-date-picker component a11y Issues related to Accessibility fixes or improvements. labels Apr 17, 2023
@geospatialem geospatialem added the estimate - 2 Small fix or update, may require updates to tests. label Jul 19, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jul 19, 2023
@jcfranco
Copy link
Member

@geospatialem This is no longer reproducible with 1.3.0+.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 0 - new New issues that need assignment. labels Jul 19, 2023
@geospatialem
Copy link
Member Author

Thanks @jcfranco, am also unable to repo in newer releases. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-datepicker Issues that pertain to the calcite-date-picker component estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Development

No branches or pull requests

2 participants