Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n Numbering Systems Testing: Issue with group separator #6607

Closed
geospatialem opened this issue Mar 15, 2023 · 3 comments
Closed

i18n Numbering Systems Testing: Issue with group separator #6607

geospatialem opened this issue Mar 15, 2023 · 3 comments
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 8 Requires input from team, consider smaller steps. i18n-l10n issues dealing with internationalization/localization impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2023 June patch p...

Comments

@geospatialem
Copy link
Member

geospatialem commented Mar 15, 2023 •
edited
Loading

Actual Behavior

In the Calcite input component:

With the locale "ar-SA" and the numberingSystem "arab", the numbers change from arab to latn after typing 5 numbers consecutively, like "12345".

via Ben:

"It looks like it is because of the group separator"

Expected Behavior

The numbers in the input to remain in the arab numbering system.

Reproduction Sample

https://codepen.io/ainermfc/pen/KKeWoOg

Reproduction Steps

  1. Set the locale to "ar-SA"
  2. Set the numberingSystem to "arab"
  3. Set dir to "rtl"
  4. Add groupSeparator
  5. Type more than 5 digits into the input

Reproduction Version

1.0.0-beta.97

Relevant Info

Spurred from #5920, which had two distinct issues. cc @annierm18 @benelan

Regression?

v1.0.0-beta.97

Priority impact

p3 - not time sensitive

Impact

No response

Esri team

N/A
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 2 - in development Issues that are actively being worked on. needs triage Planning workflow - pending design/dev review. i18n-l10n issues dealing with internationalization/localization labels Mar 15, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Mar 15, 2023
@github-actions github-actions bot added the impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive label Mar 15, 2023
@benelan benelan added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 2 - in development Issues that are actively being worked on. labels Mar 21, 2023
@brittneytewks brittneytewks added the p - low Issue is non core or affecting less that 10% of people using the library label Mar 21, 2023
@brittneytewks brittneytewks added the estimate - 8 Requires input from team, consider smaller steps. label Mar 21, 2023
@benelan benelan added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 24, 2023
@benelan
Copy link
Member

benelan commented Jun 25, 2023

Looks like @anveshmekala fixed this issue in #7173 🏆

Verified in next using the repro sample above.

@benelan benelan added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 25, 2023
@benelan benelan closed this as completed Jun 25, 2023
@github-actions github-actions bot assigned geospatialem and unassigned benelan Jun 25, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@benelan benelan added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 25, 2023
@geospatialem
Copy link
Member Author

Verified in 1.5.0-next.4.

@geospatialem geospatialem removed their assignment Jun 26, 2023
@benelan benelan mentioned this issue Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 8 Requires input from team, consider smaller steps. i18n-l10n issues dealing with internationalization/localization impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2023 June patch priorities
Development

No branches or pull requests
3 participants
@geospatialem @benelan @brittneytewks