Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal] Add --calcite-modal-content-padding CSS Variable #5957

Closed
macandcheese opened this issue Dec 8, 2022 · 4 comments
Closed

[Modal] Add --calcite-modal-content-padding CSS Variable #5957

macandcheese opened this issue Dec 8, 2022 · 4 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request.

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Dec 8, 2022

Description

We recently deprecated the noPadding property on Modal: https://developers.arcgis.com/calcite-design-system/components/modal/#component-api-properties-noPadding

The deprecation message states to use --calcite-modal-padding - which we also deprecated (correctly, since this affected padding in every element of the Modal).

We need to introduce a --calcite-modal-content-padding (or -spacing, whatever the pattern is for other instances like this, for instance in calcite-block), that lets folks re-create the noPadding functionality (or otherwise affect this padding), that is scoped just to the content slot.

Acceptance Criteria

A --calcite-modal-content-padding/spacing CSS Variable is added to calcite-modal that correctly lets folks migrate away from the deprecated noPadding property.

Relevant Info

No response

Which Component

Modal

Example Use Case

No response

Esri team

Calcite (design)

@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 8, 2022
@github-actions github-actions bot added the Calcite (design) Issues logged by Calcite designers. label Dec 8, 2022
@geospatialem geospatialem added this to the 2023 January Priorities milestone Dec 8, 2022
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Dec 8, 2022
@driskull
Copy link
Member

@macandcheese is this one is installed already?

@macandcheese
Copy link
Contributor Author

Yerp #6078

@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Dec 17, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 27, 2022
@geospatialem
Copy link
Member

Verified in beta.99 with the following css:

calcite-modal {
  --calcite-modal-content-padding: 2rem;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request.
Projects
None yet
Development

No branches or pull requests

3 participants