Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value List Item (advanced Panel) - Provide a valid label for form fields - (2036570517) #5634

Closed
Tracked by #4599
dqateam opened this issue Oct 25, 2022 · 5 comments
Closed
Tracked by #4599
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - low Issue is non core or affecting less that 10% of people using the library
Milestone

Comments

@dqateam
Copy link
Collaborator

dqateam commented Oct 25, 2022

Module:

42 Calcite Panel

Violation:

Provide a valid label for form fields

image

WCAG Reference:

Instance ID:

2036570517

Severity:

10

Description:

[Issue]
There are buttons without accessible names. Examples include:

  • Events
  • Data
  • Documents
  • Apps & Maps
  • Custom Catalog 1
  • Initiatives

[User Impact]
Screen reader users will be unable to determine the purpose of these buttons. Speech input users will have difficulty activating them.

[Code Reference]

<span class="handle" data-js-handle="" role="button" tabindex="0">
 <div aria-hidden="true" icon="drag" scale="s" calcite-hydrated="">
   (...)
 </div>
</span>

Note:

[Suggestion]
Provide a valid label for form fields. This includes providing accessible names for buttons. The accessible name of a button can be set with an aria-label attribute. Good accessible names are both concise and descriptive.

[Compliant Code Example]

<span aria-label="Events, press space and use arrow keys to reorder content. Current position 1 of 5." class="handle" data-js-handle="" role="button" tabindex="0">
 <div aria-hidden="true" icon="drag" scale="s" calcite-hydrated="">
   (...)
 </div>
</span>

Media Type:

Forms

Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Oct 25, 2022
@geospatialem geospatialem changed the title Calcite Panel - Provide a valid label for form fields - (2036570517) Calcite Value List Item (advanced Panel) - Provide a valid label for form fields - (2036570517) Nov 15, 2022
@geospatialem
Copy link
Member

geospatialem commented Nov 15, 2022

Pertains to the value-list-item component's drag-enabled.

@geospatialem geospatialem changed the title Calcite Value List Item (advanced Panel) - Provide a valid label for form fields - (2036570517) Value List Item (advanced Panel) - Provide a valid label for form fields - (2036570517) Nov 17, 2022
@driskull
Copy link
Member

I think we can defer this one for now.

@geospatialem geospatialem added the p - low Issue is non core or affecting less that 10% of people using the library label Nov 22, 2022
@geospatialem geospatialem added this to the Back burner milestone Nov 22, 2022
@brittneytewks brittneytewks removed this from the Back burner milestone May 31, 2023
@geospatialem
Copy link
Member

The handle button still does not provide context in 1.4.2. But considered a low priority with the deprecation. Leaving without a milestone for now.

@geospatialem geospatialem added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jun 1, 2023
@geospatialem geospatialem added this to the Freezer milestone Jun 22, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jun 22, 2023
@geospatialem
Copy link
Member

Adding to the freezer milestone due to the deprecated component.

@geospatialem
Copy link
Member

Closing in favor of #7426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Development

No branches or pull requests

5 participants