Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always render expected icon size to avoid layout shifts #432

Closed
jcfranco opened this issue Apr 2, 2020 · 0 comments · Fixed by #433
Closed

Always render expected icon size to avoid layout shifts #432

jcfranco opened this issue Apr 2, 2020 · 0 comments · Fixed by #433
Assignees
@jcfranco
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug.

Comments

@jcfranco
Copy link
Member

jcfranco commented Apr 2, 2020 •
edited
Loading

#351 updated calcite-icon to not render its icon element until the icon loads. This can introduce unnecessary shifts in layout and can also cause the load-when-visible logic to break.

icon-layout-shift
@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. component-icon labels Apr 2, 2020
@jcfranco jcfranco added this to the 🔨 v1-beta.22 milestone Apr 2, 2020
@jcfranco jcfranco self-assigned this Apr 2, 2020
@jcfranco jcfranco mentioned this issue Apr 2, 2020
Merged
@macandcheese macandcheese linked a pull request Apr 3, 2020 that will close this issue
fix(icon): always render in the target scale to avoid shifts in layout #433
Merged
@macandcheese macandcheese removed this from the 🔨 v1-beta.22 milestone Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(icon): always render in the target scale to avoid shifts in layout Esri/calcite-design-system
2 participants
@jcfranco @macandcheese