Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor getSlotted dom tests to run in browser #3882

Closed
driskull opened this issue Jan 7, 2022 · 1 comment
Closed

Refactor getSlotted dom tests to run in browser #3882

driskull opened this issue Jan 7, 2022 · 1 comment
Assignees
@jcfranco
Labels
1 - assigned Issues that are assigned to a sprint and a team member. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.

Comments

@driskull
Copy link
Member

driskull commented Jan 7, 2022

Description

Refactor getSlotted dom tests to run in browser

Proposed Advantages

This will allow accurate testing of getSlotted() to see if it has assignedNodes.

Relevant Info

#3788 (comment)

It might be a good idea to refactor all the dom e2e tests so that the whole utility file is able to be executed in browser for the most accurate testing.

Which Component

N/A
@driskull driskull added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 7, 2022
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Mar 30, 2023
@jcfranco
Copy link
Member

Closing, will instead work on removal with #6059. cc @geospatialem @driskull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcfranco jcfranco

Labels
1 - assigned Issues that are assigned to a sprint and a team member. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jcfranco @driskull @alisonailea @geospatialem