Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Component: calcite-input-color-picker #1616

Open
jcfranco opened this issue Feb 25, 2021 · 9 comments
Open

New Component: calcite-input-color-picker #1616

jcfranco opened this issue Feb 25, 2021 · 9 comments
Assignees
Labels
1 - assigned Issues that are assigned to a sprint and a team member. ArcGIS Online Issues logged by ArcGIS Online team members. design Issues that need design consultation prior to development. estimate - 8 Requires input from team, consider smaller steps. low risk Issues with low risk for consideration in low risk milestones new component Issues tied to a new component. p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.

Comments

@jcfranco
Copy link
Member

jcfranco commented Feb 25, 2021

Description

This component will help present a compact, inline experience for picking colors.

aa077880-24bc-11eb-9426-350e9be0fbdc

cc @mitc7862

User Stories

Acceptance Criteria

  • Allows users to save and remove colors
  • The 3 color swatches on the inline section are ordered from most recent to oldest
  • When the active color is pressed, it presents the color picker in a popover
    • The active color should update when the user clicks "done" after interacting with the color picker

Out of Scope

Helpful Details

Related issue: #950

@bstifle
Copy link

bstifle commented Aug 19, 2021

image
existing design. clicking the red would launch calcite-color-picker in a popover

related issue #1934

@jcfranco
Copy link
Member Author

@bstifle I'm not sure I follow. Would #1934 replace this one? Would it be used as a base?

@eriklharper
Copy link
Contributor

I prefer the name calcite-input-color over calcite-input-color-picker for the same reason I prefer calcite-input-time over calcite-input-time-picker. No need to have the -picker at the end when the last word is sufficient for communicating the type of input it is.

Also, the designs do appear to conflict between this issue and #1934. Do both designs need to be accommodated in the same component or is one more current than the other? I honestly prefer the simpler more compact design of #1934.

@jcfranco
Copy link
Member Author

@eriklharper You bring up a good point. The main purpose of these components is to provide a way to quickly input the value. The picking part is more of a next step when fine-tuning the value. I'm going to move this discussion to #2512.

WRT to the design, I have no preference as long as both match functionality.

@brittneytewks brittneytewks added the low risk Issues with low risk for consideration in low risk milestones label Sep 21, 2023
@brittneytewks brittneytewks added the ready for dev Issues ready for development implementation. label Oct 30, 2023
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 30, 2023
@github-actions github-actions bot removed this from the 2023 December Priorities milestone Oct 30, 2023
@github-actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@brittneytewks brittneytewks added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Oct 30, 2023
@geospatialem geospatialem added this to the 2023 December Priorities milestone Oct 30, 2023
@geospatialem geospatialem added the ArcGIS Online Issues logged by ArcGIS Online team members. label Dec 27, 2023
@brittneytewks brittneytewks added the estimate - 8 Requires input from team, consider smaller steps. label Jan 29, 2024
@geospatialem
Copy link
Member

Blocked by #10288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - assigned Issues that are assigned to a sprint and a team member. ArcGIS Online Issues logged by ArcGIS Online team members. design Issues that need design consultation prior to development. estimate - 8 Requires input from team, consider smaller steps. low risk Issues with low risk for consideration in low risk milestones new component Issues tied to a new component. p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Development

No branches or pull requests

10 participants