Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add focusTrapDisabled attribute to for non-modal dialogs #10685

Open
2 of 5 tasks
Elijbet opened this issue Nov 4, 2024 · 1 comment
Open
2 of 5 tasks

Add focusTrapDisabled attribute to for non-modal dialogs #10685

Elijbet opened this issue Nov 4, 2024 · 1 comment
Assignees
Labels
1 - assigned Issues that are assigned to a sprint and a team member. ArcGIS AppStudio Issues logged by ArcGIS AppStudio team members. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Nov 4, 2024

Check existing issues

Description

Add focusTrapDisabled attribute to non-modal dialogs, not enabled by default.

Acceptance Criteria

Non-modal dialogs offer option to disable focus-trap.

Relevant Info

As per mdn resource regarding trapping for dialog (as summed up by @geospatialem )
For non-modal dialogs it is still possible to interact with content outside of the dialog while the dialog is showing. Note that for non-modal dialogs there will have to be a global keyboard shortcut that allows focus to be moved between opened dialogs and the main page.

Which Component

dialog

Example Use Case

Example of where this is useful, a cookie page dialog that mentions cookie tracking, but the user can still interact with the page without acknowledgement/acceptance.

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)

@Elijbet Elijbet added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 4, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Nov 4, 2024
@geospatialem geospatialem added ArcGIS AppStudio Issues logged by ArcGIS AppStudio team members. p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Dec 9, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Dec 10, 2024
@ellenupp
Copy link

ellenupp commented Jan 16, 2025

We (Dashboards) would like this property back for all dialogs. We have a scenario where a modal opens a second modal and the first is hidden behind the second until the second is closed. The focus trap for the top dialog should be active, but this is no longer always the case with Calcite 3.0. There is a race condition for which focus trap gets activated. If it's the one for the bottom dialog it makes the top one unusable. A solution for us to work around this would be to disable the focus trap on the first modal until the top one is closed.

@geospatialem geospatialem added the ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. label Jan 20, 2025
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jan 21, 2025
@geospatialem geospatialem assigned Elijbet and unassigned driskull Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - assigned Issues that are assigned to a sprint and a team member. ArcGIS AppStudio Issues logged by ArcGIS AppStudio team members. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Development

No branches or pull requests

4 participants