Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): add selectedOption convenience prop #1339

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Dec 2, 2020

Related Issue: #1250

Summary

This enhances calcite-select's API with a convenience prop for the currently selected option.

Note that the prop technically be read-only, but at least it will be doc'd as such.

@jcfranco jcfranco added the enhancement Issues tied to a new feature or request. label Dec 2, 2020
@jcfranco jcfranco added this to the v1.0.0-beta.47 milestone Dec 2, 2020
@jcfranco jcfranco self-assigned this Dec 2, 2020
@jcfranco jcfranco marked this pull request as ready for review December 8, 2020 23:02
@jcfranco jcfranco requested a review from a team as a code owner December 8, 2020 23:02
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit bb4b537 into master Dec 9, 2020
@jcfranco jcfranco deleted the jcfranco/1250-add-selectedOption-prop branch December 9, 2020 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants