Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resistances showing on character sheets, but not subtracting damage during damage application #390

Closed
drywallmud opened this issue Sep 23, 2024 · 3 comments · Fixed by #393

Comments

@drywallmud
Copy link

image

using standard @system.resistances.fire.res ADD 2, but its the same across all resistances (armor resistances for instance)

@drywallmud
Copy link
Author

I should add this was noticed BEFORE the last update. My bad for not reporting it, I wanted to make sure it wasn't a goof on my part before I did.

@FoxLee
Copy link
Collaborator

FoxLee commented Oct 27, 2024

I finally have a lead on this! It looks like it's specifically a problem with damage typing from chat cards. At some point before it gets calc'd, the selected damage typing is being dropped and reverted to damage, which bypasses all typed resistances. This can be checked by adding Resist All to the character, the only resistance that applies against the damage type. (Would love you to confirm that, if you can!)

Now we just have to work out why the typing is being dropped. Will update again when I find out more!

@FoxLee
Copy link
Collaborator

FoxLee commented Oct 27, 2024

Sussed it out! The property containing the damage type has moved, so the helper that processes chat card damage needed updating. I think this should have it sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants