Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log if peer actually uses unusual feerate #6423

Open
rustyrussell opened this issue Jul 22, 2023 · 0 comments
Open

Log if peer actually uses unusual feerate #6423

rustyrussell opened this issue Jul 22, 2023 · 0 comments
Assignees

Comments

@rustyrussell
Copy link
Contributor

          > https://fedorapeople.org/~wtogami/a/2023/0001-DO-NOT-COMMIT-Temporary-workaround-for-LND-update_fe.patch Temporary workaround for v23.05.2

Your setchannel approach of runtime switchable ignore fees is far superior to temporary hack that requires restarting CLN.

Would it be possible to add a print to let you know every time an ignore fee event happened?

What I like about my ugly hack is the print tells you exactly what is happening. It is diagnostically useful to know because it should happen JUST ONCE per channel to recover from LND's bug after their fee estimator was broken in the past. If it happens more than once the remote peer's fee estimator is currently broken. You want to know that so there is a chance to talk to the sysadmin to be able to fix it. It appears this PR currently would be silent when it ignores which is less informative?

This may be possible, but the current PR works by telling channeld an infinite allowable range. I think we can do logging in lightningd however, if the actual feerate used is weird.

I will do this as a separate PR.

Originally posted by @rustyrussell in #6398 (comment)

@rustyrussell rustyrussell self-assigned this Jul 22, 2023
@rustyrussell rustyrussell added this to the v23.08 milestone Jul 22, 2023
@rustyrussell rustyrussell modified the milestones: v23.08, v23.11 Jul 31, 2023
@nepet nepet removed this from the v23.11 milestone Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants