Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fundpsbt should add fee output for elements tx #3940

Closed
niftynei opened this issue Aug 13, 2020 · 4 comments
Closed

fundpsbt should add fee output for elements tx #3940

niftynei opened this issue Aug 13, 2020 · 4 comments

Comments

@niftynei
Copy link
Contributor

fundpsbt should add (or merge, as required) a fee output for elements txs -- it's required for validation and sending.

@ZmnSCPxj
Copy link
Contributor

It would not be able to know the fees of the outputs that will be added later.

See this alternative API I proposed: #3838 (comment)

With the latter API, we can determine the fees for the outputs as well as the fee output.

@cdecker
Copy link
Member

cdecker commented Aug 14, 2020

It doesn't really have to know the fees that any later addition of inputs would result in, as long as each external tool adds or subtracts their fees to the existing fee output. I like the idea of having the psbt representation be as consistent as possible at all times.

@ZmnSCPxj
Copy link
Contributor

But it does have to know the fees of additional outputs, because it has to allocate inputs that can cover those fees as well.

@niftynei
Copy link
Contributor Author

niftynei commented Sep 2, 2020

supersumed by #3998

@niftynei niftynei closed this as completed Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants