-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix version 0.9.0.1 tracking #3928
Comments
Here's the current range-diff with the cherry-picked commits:
|
Tangent: to avoid visual confusion between 0.9.0.1 and 0.9.1, I suggest numbering the next release after this hotfix as 0.9.2 instead. |
How about #3914 as well? It reduces the chances of degenerate splits (#3926) when paying to unpublished nodes in general, due to being less aggressive with routehints in all cases (08e128e), not just blockheight disagreement; the blockheight-disagreement case is the easiest way to trigger it in a test but it can also trigger by chance when others are paying through the public network near your destination. We probably need to think more about adaptive splitting and maybe optimistically dropping channel hints but that is probably not enough time in a hotfix, whereas #3914 is practically complete at this point. |
How about calling out the difference by using a different point separator like v0.9.0~1 or v0.9.0-1? I'd like not having to change the numbering scheme, which always ends up confusing people. |
I'd prefer not having this one in because a) the waitblockheight modifier is unlikely to ever be hit, b) it changes substantially the order in which we iterate over the routehints and I'd like to get more feedback on it being correct first. This really is a hotfix release, so we should only include fixes for issues that impede correct usage and impacts a sufficiently large number of users. |
(a) The core fix is not related to |
Ok, you convinced me, I'll cherry-pick the commits into the release :-) |
That is better IMO. |
Ok, cherry-picked #3914 onto the hotfix release branch and updated the above range-diff. Now testing and publishing the release if all goes well. |
Given that a number of bugs snuck their way into the v0.9.0 release (mainly through my own omissions in the
pay
plugin), we're going to do a small hotfix/point release with the backported fixes for those issues.Below is the list of issues / PRs we're going to include in the v0.9.0.1 release (reported here because we can't open PRs that merge on a tag):
msatoshi
andpayment_hash
to payments performed via thepay
command and return them vialistpays
listpays
#3909 : addcreated_at
tolistpays
result. This and the previous ones were included because spark-wallet needed to work around them.presplit
modifier split the initial payment amount.presplit
modifier could result in thebolt11
not being added to a payment, which could then crash calls tolistpays
.Please let me know if there's anything else that is absolutely critical to include in the hotfix release. Here's a list of commits included in this hotfix release: v0.9.0...v0.9.0.1
The text was updated successfully, but these errors were encountered: