Table: fix data is null and rowKey or defaultExpandAll error. #16303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix toggleTreeExpansion method lack of rigorous judgement.
|
Deploy preview for element ready! Built with commit dedea38 |
|
related #16304 |
ziyoung
reviewed
Jul 4, 2019
| @@ -13,6 +13,7 @@ export default { | |||
| methods: { | |||
| updateExpandRows() { | |||
| const { data = [], rowKey, defaultExpandAll, expandRows } = this.states; | |||
| if (!data) return; | |||
| const oldExpanded = treeData[id].expanded; | ||
| if (id && data && ('expanded' in data)) { | ||
| if (id && ('expanded' in data)) { |
There was a problem hiding this comment.
代码可以优化一下
- const oldExpanded = treeData[id].expanded;
+ const oldExpanded = data.expanded;并且这一行还可以移到 if 语句中。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.