Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: clearSort support custom sort method(#13873) #13942

Closed
wants to merge 1 commit into from
Closed

Table: clearSort support custom sort method(#13873) #13942

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 30, 2018

fix #13873.
While table-column has a custom sort method, clearSort() doesn’t assign state._data(the original table data) to states.data, so I updated the if condition.

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@element-bot
Copy link
Member

Deploy preview for element ready!

Built with commit d6d616e

https://deploy-preview-13942--element.netlify.com

@island205 island205 self-requested a review January 9, 2019 07:09
@ghost ghost closed this Mar 14, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Table clearSort() doesn't work on custom sort.
1 participant