From 635bdcb41cb5669806383d8171c89f911ca69bbc Mon Sep 17 00:00:00 2001 From: Jack Pope Date: Mon, 11 Mar 2024 15:06:35 -0400 Subject: [PATCH] Concurrent rendering in ReactDevToolsHooksIntegration-test (#28522) ## Summary We need to unblock flipping the default for RTR to be concurrent rendering. Update ReactDevToolsHooksIntegration-test to use `unstable_isConcurrent` in place. ## How did you test this change? `yarn test packages/react-debug-tools/src/__tests__/ReactDevToolsHooksIntegration-test.js` --- .../ReactDevToolsHooksIntegration-test.js | 45 +++++++++++++------ 1 file changed, 31 insertions(+), 14 deletions(-) diff --git a/packages/react-debug-tools/src/__tests__/ReactDevToolsHooksIntegration-test.js b/packages/react-debug-tools/src/__tests__/ReactDevToolsHooksIntegration-test.js index eabcbd215bfb2..9c38c5d832f7e 100644 --- a/packages/react-debug-tools/src/__tests__/ReactDevToolsHooksIntegration-test.js +++ b/packages/react-debug-tools/src/__tests__/ReactDevToolsHooksIntegration-test.js @@ -43,7 +43,7 @@ describe('React hooks DevTools integration', () => { const InternalTestUtils = require('internal-test-utils'); waitForAll = InternalTestUtils.waitForAll; - act = ReactTestRenderer.act; + act = require('internal-test-utils').act; }); it('should support editing useState hooks', async () => { @@ -55,7 +55,12 @@ describe('React hooks DevTools integration', () => { return
count:{count}
; } - const renderer = ReactTestRenderer.create(); + let renderer; + await act(() => { + renderer = ReactTestRenderer.create(, { + unstable_isConcurrent: true, + }); + }); expect(renderer.toJSON()).toEqual({ type: 'div', props: {}, @@ -107,7 +112,12 @@ describe('React hooks DevTools integration', () => { ); } - const renderer = ReactTestRenderer.create(); + let renderer; + await act(() => { + renderer = ReactTestRenderer.create(, { + unstable_isConcurrent: true, + }); + }); expect(renderer.toJSON()).toEqual({ type: 'div', props: {}, @@ -155,7 +165,12 @@ describe('React hooks DevTools integration', () => { return
count:{count}
; } - const renderer = ReactTestRenderer.create(); + let renderer; + await act(() => { + renderer = ReactTestRenderer.create(, { + unstable_isConcurrent: true, + }); + }); expect(renderer.toJSON()).toEqual({ type: 'div', props: {}, @@ -192,14 +207,17 @@ describe('React hooks DevTools integration', () => { function MyComponent() { return 'Done'; } - - const renderer = ReactTestRenderer.create( -
- - - -
, - ); + let renderer; + await act(() => { + renderer = ReactTestRenderer.create( +
+ + + +
, + {unstable_isConcurrent: true}, + ); + }); const fiber = renderer.root._currentFiber().child; if (__DEV__) { // First render was locked @@ -236,7 +254,6 @@ describe('React hooks DevTools integration', () => { } }); - // @gate __DEV__ it('should support overriding suspense in concurrent mode', async () => { if (__DEV__) { // Lock the first render @@ -254,7 +271,7 @@ describe('React hooks DevTools integration', () => { , - {isConcurrent: true}, + {unstable_isConcurrent: true}, ), );