Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase precision of Slow Up/Slow Down for surface controllers #4593

Closed
1 task done
kmf123kmf opened this issue Feb 1, 2024 · 5 comments · Fixed by #4612
Closed
1 task done

Increase precision of Slow Up/Slow Down for surface controllers #4593

kmf123kmf opened this issue Feb 1, 2024 · 5 comments · Fixed by #4612
Labels
enhancement ✨ New feature or request

Comments

@kmf123kmf
Copy link

Is there an existing issue for this feature request?

  • I have searched the existing issues

Is your feature request related to a problem?

Mixer Slow Up and Slow Down precision of 100ms is insufficient for surface vehicle steering and throttle use.

Describe the solution you'd like

For surface controllers (ie Radiomaster MT12) the mixer Slow Up and Slow Down values should have 10ms precision instead of the current 100ms.

Describe alternatives you've considered

No response

Additional context

Many racer oriented surface controllers implement a servo "speed" setting. Futaba and Sanwa use a 0-100 percentage style value system while Flysky uses time based values. This setting can be reasonably emulated using EdgeTX mixer Slow Up/Down settings, but the resolution is not granular enough to dial-in the exact "feel" a driver may be looking to achieve.

Setting on Flysky NB4 for reference:

image

Note: Other surface systems use the concept of "away from center" and "return to center" speed settings. While EdgeTX does not appear to have this concept at the mixer level, I believe that simply setting Up and Down to the same value would be sufficient for most users.

@kmf123kmf kmf123kmf added the enhancement ✨ New feature or request label Feb 1, 2024
@philmoz
Copy link
Collaborator

philmoz commented Feb 6, 2024

Currently the speed up/down values have a range of 0s - 25.5s (stored as an 8 bit unsigned integer).

If we add a setting to allow 10ms precision then you would only get a range of 0s - 2.5s - is this sufficient?

Would the precision setting for speed up/down be for the entire model (affecting all mix lines) or would you want to set it individually for each mix line?

@kmf123kmf
Copy link
Author

In the context of a race vehicle, 2.5s is way more than enough. With this in mind, I think a setting at the model level would be ideal. I can't imagine any scenario where someone would need 10ms precision AND super slow movement speed in the same surface model.

For what it's worth, I was able to hack my way through a POC build for the MT12 and it wasn't too bad. Just had to watch out because currently the SLOW and DELAY editing seem to be tied to the same code.

@kmf123kmf
Copy link
Author

I think a setting at the model level would be ideal...

So I've reconsidered this. The high precision would typically only ever be needed on a steering channel, so the ideal scenario would be a per mixer setting as this affords the highest level of flexibility to the user. But, if it is easier/more convenient/cleaner/etc. to have single setting per model, this would be perfectly acceptable as well IMO.

@philmoz
Copy link
Collaborator

philmoz commented Feb 7, 2024

@kmf123kmf PR #4612 implements this if you want to test it. Precision is set per mix line.

@kmf123kmf
Copy link
Author

Works perfectly on my MT12. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants