Automatically uncheck a label when checking a second label results in no models

[MattCarothers]

Is there an existing issue for this feature request?

• I have searched the existing issues

Is your feature request related to a problem?

Several of my label groups are mutually exclusive. E.g. I have an "EDF" group for fixed wing EDF jets, and I have a "Heli" group for helicopters. The union of those two sets is empty, so if I check both boxes, I get no models. In order to switch from EDF to Heli, I have to first uncheck EDF and then check Heli.

Describe the solution you'd like

I'd love to be able to select a label and have the radio automatically uncheck the previous label(s) if the resulting model list would be empty. If selecting multiple labels results in at least one model being displayed, the behavior should remain the same as it is currently.

Describe alternatives you've considered

Today I just manually uncheck the first label before checking the new one.

Additional context

Current behavior: selecting a second label results in no models shown because there are no models with both labels.

Desired behavior: selecting the second label should unselect the first label in cases where the combination yields no models.

[MRC3742]

I also find this issue as "not user friendly" needing multiple inputs to get to a specific label category.

A different approach with the same end result would be to have a separate option to allow "Multiple label selections".
If this new option was not enabled (checked) then selecting a new label category would deselect the current one.

If this makes sense? - Rich

[pfeerick]

Just FYI, this is mentioned in passing in #4122, and I thought it was actually mentioned in an older issue, but can't place it. It could even be in the initial discussion for the labels feature, and it was something to be added later, as the current UI controls wouldn't readily allow for that for the touch UI.

A workaround for this is to use the page hardware keys (where present), as they move from label to label, rather than multi-selecting labels.

[MattCarothers]

A different approach with the same end result would be to have a separate option to allow "Multiple label selections". If this new option was not enabled (checked) then selecting a new label category would deselect the current one.

That was my first thought as well, but I do actually have categories that intersect. Like some of my warbirds are also EDFs, and it's intuitive to be able to select both at the same time. I couldn't think of a better way to keep both functionalities than to check the results of the union for an empty set.

[pfeerick]

Another possibility might be to have it so it's a long press to tick more than one label if we can capture that event? So a normal short press only activates one label at a time, and if you long press on a second label, it adds that label to the filter.

[philmoz]

I'd love to be able to select a label and have the radio automatically uncheck the previous label(s) if the resulting model list would be empty.

I don't see how the logic for this would work and not confuse people.
Sometimes when you select a label there would be multiple labels selected, other times previously selected labels would get unselected. I can see this causing complaints.

Also if you had multiple labels selected and the next one results in no models, how does the code decide which of the previous ones to unselect.

[jtaylor2]

I think the problem is that most people don't understand (or want) how multiselect works. They don't realize it is a filter for multiple labels and they don't need or use multiple labels so it's just an inconvenience to have to deselect a label to select a different one. They were either used to the way the old categories worked or the way single select works most everywhere (you select a new label it deselects the old one radio button style). The 5 or 6 people using edgeTX at the 4 clubs to which I belong have labels like Electric, Gas, Glow, Glider, Heli. They just put models in one "category" they don't do something like tag Heli-Electric or Heli-Glow they just tag them all Heli. When used that way multiselect requires an inconvenient extra click to deselect the old label.

I'm sure there are people that use multiple labels, after all somebody decided to implement it as a multiselect filter instead of radio buttons, but it would be interesting to know the percentages.

[Astrohog]

I agree that most ppl don't use or require the multiselect feature. I don't but I imagine a small percent do. A long press could be an option. Long press on a selected label would produce the label menu while a long press on an unselected label would select it. Another option would be to use a double tap to select a label while deselecting all others. This action works well for the "model quick select" feature that I use extensively. FYI this option is turned on at the bottom of the System-Radio setup tab.

[jtaylor2]

How about a radio option to change between multiselect and single select the way "Model Quick Select" does for models? That would make labels work more like the old categories did.

My programming was assembler in the 1960's and K&R C in the 70's so I'm struggling with how to add a radio option (g_eeGeneral.labelSingleSelect) but I've done a proof of concept overloading "Model quick select" to also do "Label single select".

I'll add a diff for model_select.cpp so that anyone who can compile the code can comment on the concept and if it is worth pursuing (only tested on simu).

Edit: Attached corrected diff in next comment -this one is incorrect
model_select.cpp.diff.txt

[jtaylor2]

model_select.cpp.diff.txt