Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FM Global Variables #2498

Open
1 task done
CarlKnox opened this issue Oct 9, 2022 · 6 comments
Open
1 task done

FM Global Variables #2498

CarlKnox opened this issue Oct 9, 2022 · 6 comments
Labels
color Related generally to color LCD radios enhancement ✨ New feature or request UX-UI Related to user experience (UX) or user interface (UI) behaviour
Milestone

Comments

@CarlKnox
Copy link

CarlKnox commented Oct 9, 2022

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

v2.7 would list the GV1-9 in each FM so you could label them or see how they change as switches are thrown.
v2.8 rc2 does not show GV.
I have widgets using GV, so I know they are still in use and working. I just can't see them from the Tx.

Expected Behavior

Add GV to FMs similar to Trims, perhaps.

Steps To Reproduce

Press Model button
Select Flight Mode
Select FM0
image

Version

Other (Please specify below)

Transmitter

Radiomaster TX16S / TX16SMK2

Anything else?

v2.8.0-rc2

@CarlKnox CarlKnox added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Oct 9, 2022
@pfeerick
Copy link
Member

pfeerick commented Oct 9, 2022

Are you sure you're not confusing the FM tab with the GVs tab? This is the FM tab from 2.7...
image
... and this is the GV tab (which is exactly the same in 2.8 as it hasn't been touched... yet!)...
image

@CarlKnox
Copy link
Author

Maybe move this to a feature.
I'm thinking if GV can see (monitor) FM, then FM should also see GV.

@pfeerick pfeerick added enhancement ✨ New feature or request and removed bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Oct 10, 2022
@pfeerick
Copy link
Member

I guess then really need to think about:

  • what is the purpose/benefit of showing it in the Flight Modes screen (as opposed to pre-existing GV screen)?
  • how would it look?
  • how would it work?

@raphaelcoeffic
Copy link
Member

@pfeerick A friend of mine kept bugging me with this as well. The point is: you can witness it on the 128x64 UI (and only there!).

I think basically having a table with the GVs and values.

@raphaelcoeffic raphaelcoeffic added this to the 2.9 milestone Oct 10, 2022
@pfeerick
Copy link
Member

lol... ah, ok, so the 128x64 doesn't have a GV page at all... that would explain it 🤣

Interesting... so people actually want the regression in capability of the 128x64 B&W UI (since the 212x64 B&W UI also shows like colorlcd)? Where you have to go into a flight mode to see the GVs? As opposed to being able to see all the GVs at once and which flight mode is using them? I bet not... pretty sure they want it both ways, and the cake too! 🤣 So that's what they'll get (not the cake, I'm keeping that!).

@pfeerick pfeerick added UX-UI Related to user experience (UX) or user interface (UI) behaviour color Related generally to color LCD radios labels Oct 11, 2022
@raphaelcoeffic
Copy link
Member

Sometimes you might want to set the GV for a single flight mode, thus editing more than one at the same time, and sometimes you might prefer to edit a GV for all flight modes at the same time. Really depends on what you’re trying to achieve.

@pfeerick pfeerick modified the milestones: 2.9, 2.10 Apr 14, 2023
@pfeerick pfeerick modified the milestones: 2.10, 2.11 Dec 12, 2023
@gagarinlg gagarinlg modified the milestones: 2.11, 3.0 Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color Related generally to color LCD radios enhancement ✨ New feature or request UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

No branches or pull requests

4 participants